From: Wanlong Gao <gaowanlong@cn.fujitsu.com>
To: JJ Ding <jj_ding@emc.com.tw>
Cc: linux-input@vger.kernel.org,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
JJ Ding <dgdunix@gmail.com>
Subject: Re: [PATCH] Input: psmouse - change log messages from psmouse.c to psmouse
Date: Thu, 29 Sep 2011 13:17:53 +0800 [thread overview]
Message-ID: <4E83FF81.700@cn.fujitsu.com> (raw)
In-Reply-To: <1317273295-4931-1-git-send-email-jj_ding@emc.com.tw>
On 09/29/2011 01:14 PM, JJ Ding wrote:
> From: JJ Ding <dgdunix@gmail.com>
>
> psmouse.c had long been renamed to psmouse-base.c back in 2003, when we
> were still at Linux 2.5.xx. This change makes the log less misleading.
>
> Signed-off-by: JJ Ding <dgdunix@gmail.com>
Reviewed-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> ---
> drivers/input/mouse/psmouse-base.c | 22 +++++++++++-----------
> 1 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/input/mouse/psmouse-base.c b/drivers/input/mouse/psmouse-base.c
> index 3f74bae..6a2584d 100644
> --- a/drivers/input/mouse/psmouse-base.c
> +++ b/drivers/input/mouse/psmouse-base.c
> @@ -251,11 +251,11 @@ static int psmouse_handle_byte(struct psmouse *psmouse)
> switch (rc) {
> case PSMOUSE_BAD_DATA:
> if (psmouse->state == PSMOUSE_ACTIVATED) {
> - printk(KERN_WARNING "psmouse.c: %s at %s lost sync at byte %d\n",
> + printk(KERN_WARNING "psmouse: %s at %s lost sync at byte %d\n",
> psmouse->name, psmouse->phys, psmouse->pktcnt);
> if (++psmouse->out_of_sync_cnt == psmouse->resetafter) {
> __psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> - printk(KERN_NOTICE "psmouse.c: issuing reconnect request\n");
> + printk(KERN_NOTICE "psmouse: issuing reconnect request\n");
> serio_reconnect(psmouse->ps2dev.serio);
> return -1;
> }
> @@ -267,7 +267,7 @@ static int psmouse_handle_byte(struct psmouse *psmouse)
> psmouse->pktcnt = 0;
> if (psmouse->out_of_sync_cnt) {
> psmouse->out_of_sync_cnt = 0;
> - printk(KERN_NOTICE "psmouse.c: %s at %s - driver resynched.\n",
> + printk(KERN_NOTICE "psmouse: %s at %s - driver resynched.\n",
> psmouse->name, psmouse->phys);
> }
> break;
> @@ -295,7 +295,7 @@ static irqreturn_t psmouse_interrupt(struct serio *serio,
> ((flags & SERIO_PARITY) && !psmouse->ignore_parity))) {
>
> if (psmouse->state == PSMOUSE_ACTIVATED)
> - printk(KERN_WARNING "psmouse.c: bad data from KBC -%s%s\n",
> + printk(KERN_WARNING "psmouse: bad data from KBC -%s%s\n",
> flags & SERIO_TIMEOUT ? " timeout" : "",
> flags & SERIO_PARITY ? " bad parity" : "");
> ps2_cmd_aborted(&psmouse->ps2dev);
> @@ -315,7 +315,7 @@ static irqreturn_t psmouse_interrupt(struct serio *serio,
>
> if (psmouse->state == PSMOUSE_ACTIVATED &&
> psmouse->pktcnt && time_after(jiffies, psmouse->last + HZ/2)) {
> - printk(KERN_INFO "psmouse.c: %s at %s lost synchronization, throwing %d bytes away.\n",
> + printk(KERN_INFO "psmouse: %s at %s lost synchronization, throwing %d bytes away.\n",
> psmouse->name, psmouse->phys, psmouse->pktcnt);
> psmouse->badbyte = psmouse->packet[0];
> __psmouse_set_state(psmouse, PSMOUSE_RESYNCING);
> @@ -943,7 +943,7 @@ static int psmouse_probe(struct psmouse *psmouse)
> */
>
> if (ps2_command(ps2dev, NULL, PSMOUSE_CMD_RESET_DIS))
> - printk(KERN_WARNING "psmouse.c: Failed to reset mouse on %s\n", ps2dev->serio->phys);
> + printk(KERN_WARNING "psmouse: Failed to reset mouse on %s\n", ps2dev->serio->phys);
>
> return 0;
> }
> @@ -1005,7 +1005,7 @@ static void psmouse_initialize(struct psmouse *psmouse)
> static void psmouse_activate(struct psmouse *psmouse)
> {
> if (ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_ENABLE))
> - printk(KERN_WARNING "psmouse.c: Failed to enable mouse on %s\n",
> + printk(KERN_WARNING "psmouse: Failed to enable mouse on %s\n",
> psmouse->ps2dev.serio->phys);
>
> psmouse_set_state(psmouse, PSMOUSE_ACTIVATED);
> @@ -1020,7 +1020,7 @@ static void psmouse_activate(struct psmouse *psmouse)
> static void psmouse_deactivate(struct psmouse *psmouse)
> {
> if (ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_DISABLE))
> - printk(KERN_WARNING "psmouse.c: Failed to deactivate mouse on %s\n",
> + printk(KERN_WARNING "psmouse: Failed to deactivate mouse on %s\n",
> psmouse->ps2dev.serio->phys);
>
> psmouse_set_state(psmouse, PSMOUSE_CMD_MODE);
> @@ -1115,14 +1115,14 @@ static void psmouse_resync(struct work_struct *work)
> }
>
> if (!enabled) {
> - printk(KERN_WARNING "psmouse.c: failed to re-enable mouse on %s\n",
> + printk(KERN_WARNING "psmouse: failed to re-enable mouse on %s\n",
> psmouse->ps2dev.serio->phys);
> failed = true;
> }
>
> if (failed) {
> psmouse_set_state(psmouse, PSMOUSE_IGNORE);
> - printk(KERN_INFO "psmouse.c: resync failed, issuing reconnect request\n");
> + printk(KERN_INFO "psmouse: resync failed, issuing reconnect request\n");
> serio_reconnect(serio);
> } else
> psmouse_set_state(psmouse, PSMOUSE_ACTIVATED);
> @@ -1155,7 +1155,7 @@ static void psmouse_cleanup(struct serio *serio)
> * Disable stream mode so cleanup routine can proceed undisturbed.
> */
> if (ps2_command(&psmouse->ps2dev, NULL, PSMOUSE_CMD_DISABLE))
> - printk(KERN_WARNING "psmouse.c: Failed to disable mouse on %s\n",
> + printk(KERN_WARNING "psmouse: Failed to disable mouse on %s\n",
> psmouse->ps2dev.serio->phys);
>
> if (psmouse->cleanup)
next prev parent reply other threads:[~2011-09-29 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 5:14 [PATCH] Input: psmouse - change log messages from psmouse.c to psmouse JJ Ding
2011-09-29 5:17 ` Wanlong Gao [this message]
2011-10-07 6:39 ` Dmitry Torokhov
2011-10-07 8:15 ` Wanlong Gao
2011-10-07 9:30 ` JJ Ding
2011-10-07 10:07 ` Daniel Kurtz
2011-10-11 1:22 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E83FF81.700@cn.fujitsu.com \
--to=gaowanlong@cn.fujitsu.com \
--cc=dgdunix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jj_ding@emc.com.tw \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).