From: Jonathan Cameron <jic23@cam.ac.uk>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: dmitry.torokhov@gmail.com, sameo@linux.intel.com,
peter.ujfalusi@ti.com, aghayal@codeaurora.org, david@hardeman.nu,
Shubhrajyoti@ti.com, saaguirre@ti.com, hemanthv@ti.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/5] input/cma3000_d0x: Keep configuration on poweroff
Date: Tue, 18 Oct 2011 09:35:17 +0100 [thread overview]
Message-ID: <4E9D3A45.1040103@cam.ac.uk> (raw)
In-Reply-To: <1318926486-10330-4-git-send-email-ricardo.ribalda@gmail.com>
On 10/18/11 09:28, Ricardo Ribalda Delgado wrote:
> When the device goes to poweroff keep the spi/i2c configuration.
> Otherwhise the device could not wake up if it was in spi mode.
>
Run checkpatch.pl over these
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/input/misc/cma3000_d0x.c | 6 +++++-
> 1 files changed, 5 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c
> index 9899742..15577b7 100644
> --- a/drivers/input/misc/cma3000_d0x.c
> +++ b/drivers/input/misc/cma3000_d0x.c
> @@ -44,6 +44,7 @@
> #define CMA3000_RANGE2G (1 << 7)
> #define CMA3000_RANGE8G (0 << 7)
> #define CMA3000_BUSI2C (0 << 4)
> +#define CMA3000_BUSSPI (1 << 4)
> #define CMA3000_MODEMASK (7 << 1)
> #define CMA3000_GRANGEMASK (1 << 7)
>
> @@ -230,8 +231,11 @@ static int cma3000_poweron(struct cma3000_accl_data *data)
> static int cma3000_poweroff(struct cma3000_accl_data *data)
> {
> int ret;
> + u8 ctrl = CMAMODE_POFF;
>
> - ret = CMA3000_SET(data, CMA3000_CTRL, CMAMODE_POFF, "Mode setting");
> + ctrl |= data->bus_ops->ctrl_mod;
> +
> + ret = CMA3000_SET(data, CMA3000_CTRL , ctrl, "Mode setting");
no space before comma.
> msleep(CMA3000_SETDELAY);
>
> return ret;
next prev parent reply other threads:[~2011-10-18 8:35 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 8:28 [PATCH 0/5] Add spi support for CMA3000 driver and new driver CMR3000 Ricardo Ribalda Delgado
2011-10-18 8:28 ` [PATCH 1/5] input/cma3000_d0x: Support devices without pdata Ricardo Ribalda Delgado
2011-10-18 8:28 ` [PATCH 2/5] input/cma3000_d0x: Check silicon version Ricardo Ribalda Delgado
2011-10-18 8:28 ` [PATCH 3/5] input/cma3000_d0x: Keep configuration on poweroff Ricardo Ribalda Delgado
2011-10-18 8:28 ` [PATCH 4/5] input/cma3000_d0x: Add CMA3000 spi support Ricardo Ribalda Delgado
2011-10-18 8:44 ` Jonathan Cameron
2011-10-18 8:28 ` [PATCH 5/5] Input: add CMR3000 gyrsocope driver Ricardo Ribalda Delgado
2011-10-18 8:54 ` Jonathan Cameron
2011-10-18 12:07 ` Ricardo Ribalda Delgado
[not found] ` <1318926486-10330-2-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 8:32 ` [PATCH 1/5] input/cma3000_d0x: Support devices without pdata Jonathan Cameron
2011-10-18 12:07 ` Ricardo Ribalda Delgado
2011-10-18 12:51 ` Jonathan Cameron
[not found] ` <1318926486-10330-3-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 8:34 ` [PATCH 2/5] input/cma3000_d0x: Check silicon version Jonathan Cameron
2011-10-18 12:07 ` Ricardo Ribalda Delgado
[not found] ` <1318926486-10330-4-git-send-email-ricardo.ribalda@gmail.com>
2011-10-18 8:35 ` Jonathan Cameron [this message]
2011-10-18 12:07 ` [PATCH 3/5] input/cma3000_d0x: Keep configuration on poweroff Ricardo Ribalda Delgado
2011-10-18 12:45 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E9D3A45.1040103@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Shubhrajyoti@ti.com \
--cc=aghayal@codeaurora.org \
--cc=david@hardeman.nu \
--cc=dmitry.torokhov@gmail.com \
--cc=hemanthv@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=ricardo.ribalda@gmail.com \
--cc=saaguirre@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).