From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [PATCHv2 2/7] input/cma3000_d0x: Check silicon version Date: Tue, 18 Oct 2011 13:54:39 +0100 Message-ID: <4E9D770F.90700@cam.ac.uk> References: <1318939596-27330-1-git-send-email-ricardo.ribalda@gmail.com> <1318939596-27330-3-git-send-email-ricardo.ribalda@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from ppsw-52.csi.cam.ac.uk ([131.111.8.152]:42871 "EHLO ppsw-52.csi.cam.ac.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751240Ab1JRMyg (ORCPT ); Tue, 18 Oct 2011 08:54:36 -0400 In-Reply-To: <1318939596-27330-3-git-send-email-ricardo.ribalda@gmail.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Ricardo Ribalda Delgado Cc: dmitry.torokhov@gmail.com, sameo@linux.intel.com, peter.ujfalusi@ti.com, aghayal@codeaurora.org, david@hardeman.nu, Shubhrajyoti@ti.com, saaguirre@ti.com, hemanthv@ti.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On 10/18/11 13:06, Ricardo Ribalda Delgado wrote: > Improve probing of the cma3000 chip, by checking the revision of the > device. > > --- > > v2: Fixes suggested by Jonathan Cameron > -Remove WhoamI pr_info > > Signed-off-by: Ricardo Ribalda Delgado Acked-by: Jonathan Cameron > --- > drivers/input/misc/cma3000_d0x.c | 8 +++++++- > 1 files changed, 7 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/misc/cma3000_d0x.c b/drivers/input/misc/cma3000_d0x.c > index f2e87e3..3877cbe 100644 > --- a/drivers/input/misc/cma3000_d0x.c > +++ b/drivers/input/misc/cma3000_d0x.c > @@ -26,6 +26,8 @@ > > #include "cma3000_d0x.h" > > +#define CMA3000_REV 0x10 > + > #define CMA3000_WHOAMI 0x00 > #define CMA3000_REVID 0x01 > #define CMA3000_CTRL 0x02 > @@ -366,7 +368,11 @@ struct cma3000_accl_data *cma3000_init(struct device *dev, int irq, > error = rev; > goto err_free_mem; > } > - > + if (rev != CMA3000_REV) { > + error = -EINVAL; > + pr_err("CMA3000 Accelerometer: Unknown Revision %x\n", rev); > + goto err_free_mem; > + } > pr_info("CMA3000 Accelerometer: Revision %x\n", rev); > > error = request_threaded_irq(irq, NULL, cma3000_thread_irq,