From: Jonathan Cameron <jic23@cam.ac.uk>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
dmitry.torokhov@gmail.com, sameo@linux.intel.com,
peter.ujfalusi@ti.com, aghayal@codeaurora.org, david@hardeman.nu,
Shubhrajyoti@ti.com, saaguirre@ti.com, hemanthv@ti.com,
linux-input@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@opensource.wolfsonmicro.com>
Subject: Re: [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support
Date: Tue, 25 Oct 2011 09:32:27 +0100 [thread overview]
Message-ID: <4EA6741B.6090508@cam.ac.uk> (raw)
In-Reply-To: <CAPybu_3pF6u10JMmcbho1e7=8EPHMq8LQ1+uHpyVMOmbRMUsHA@mail.gmail.com>
On 10/25/11 08:24, Ricardo Ribalda Delgado wrote:
> Hello Grant
>
> Thanks for your comments. I am fixing the --- problem in all the patches.
>
>>
>> Mark Brown had posted a generic indirect register read/write library
>> that I believe is getting merged. Maybe this driver should be using
>> it?
>
> It is not on linux-next, and also it cannot be used directly, in order
> to read you have to do set reg= (reg << 2) | 2; And AFAIK it is not
> supported by the regmap
My gut feeling is it would easy enough to add if it can't currently
be done. Mark?
Gains here are leveraging the bus abstractions from there. There aren't
enough registers to gain from caching etc.
>
>>
>> Drop the .bus line. The core code does this bit for you.
>
> Done
>
>>> +module_init(cma3000_spi_init);
>>> +module_exit(cma3000_spi_exit);
>>
>> move module_init() directly below the function it registers.
>
> Also done, but I believe the other is more elegant :)
>>
>>> +
>>> +MODULE_DESCRIPTION("CMA3000-D0x Accelerometer SPI Driver");
>>> +MODULE_LICENSE("GPL");
>>> +MODULE_AUTHOR("Ricardo Ribalda <ricardo.ribalda@gmail.com>");
>>> --
>>> 1.7.7
>>>
>>
>
>
>
next prev parent reply other threads:[~2011-10-25 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-24 20:21 [PATCHv4 0/6] Add spi support for CMA3000 driver and new driver CMR3000 Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 1/6] input/cma3000_d0x: Support devices without pdata Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 2/6] input/cma3000_d0x: Check silicon version Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 3/6] input/cma3000_d0x: Keep configuration on poweroff Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 5/6] Input: add CMR3000 gyrsocope driver Ricardo Ribalda Delgado
2011-10-24 21:40 ` Grant Likely
2011-10-25 7:26 ` Ricardo Ribalda Delgado
2011-10-25 8:28 ` Grant Likely
2011-11-02 14:28 ` Ricardo Ribalda Delgado
2011-10-24 20:21 ` [PATCHv4 6/6] input/cma3000_d0x: Match comment to name of struct Ricardo Ribalda Delgado
[not found] ` <1319487676-27181-2-git-send-email-ricardo.ribalda@gmail.com>
2011-10-24 21:31 ` [PATCHv4 1/6] input/cma3000_d0x: Support devices without pdata Grant Likely
2011-10-25 7:38 ` Ricardo Ribalda Delgado
2011-10-25 7:46 ` Grant Likely
2011-11-02 12:41 ` Ricardo Ribalda Delgado
2011-11-02 14:51 ` Ricardo Ribalda Delgado
[not found] ` <1319487676-27181-5-git-send-email-ricardo.ribalda@gmail.com>
2011-10-24 21:36 ` [PATCHv4 4/6] input/cma3000_d0x: Add CMA3000 spi support Grant Likely
2011-10-25 7:24 ` Ricardo Ribalda Delgado
2011-10-25 8:29 ` Grant Likely
2011-10-25 8:32 ` Jonathan Cameron [this message]
2011-10-25 8:36 ` Mark Brown
2011-11-02 12:38 ` Ricardo Ribalda Delgado
2011-11-02 12:49 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA6741B.6090508@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Shubhrajyoti@ti.com \
--cc=aghayal@codeaurora.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=david@hardeman.nu \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=hemanthv@ti.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.ujfalusi@ti.com \
--cc=ricardo.ribalda@gmail.com \
--cc=saaguirre@ti.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).