From: Chase Douglas <chase.douglas@canonical.com>
To: Seth Forshee <seth.forshee@canonical.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Alessandro Rubini <rubini@cvml.unipv.it>,
Henrik Rydberg <rydberg@euromail.se>,
Andrew Skalski <askalski@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/7] Input: ALPS - Remove assumptions about packet size
Date: Mon, 07 Nov 2011 13:31:59 -0800 [thread overview]
Message-ID: <4EB84E4F.5020502@canonical.com> (raw)
In-Reply-To: <1320699160-28492-5-git-send-email-seth.forshee@canonical.com>
On 11/07/2011 12:52 PM, Seth Forshee wrote:
> In preparation for version 4 protocol support, which has 8-byte
> data packets, remove all hard-coded assumptions about packet size
> and use psmouse->pktsize instead.
>
> Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
The stack allocated buffer is much cleaner :).
Acked-by: Chase Douglas <chase.douglas@canonical.com>
next prev parent reply other threads:[~2011-11-07 21:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 20:52 [PATCH v2 0/7] Additional ALPS touchpad protocol support Seth Forshee
2011-11-07 20:52 ` [PATCH v2 1/7] Input: ALPS - Move protocol information to Documentation Seth Forshee
2011-11-07 20:52 ` [PATCH v2 2/7] Input: psmouse - Add PSMOUSE_CMD_RESET_WRAP Seth Forshee
2011-11-07 20:52 ` [PATCH v2 3/7] Input: ALPS - Add protocol version field in alps_model_info Seth Forshee
2011-11-07 20:52 ` [PATCH v2 4/7] Input: ALPS - Remove assumptions about packet size Seth Forshee
2011-11-07 21:31 ` Chase Douglas [this message]
2011-11-07 20:52 ` [PATCH v2 5/7] Input: ALPS - Add support for protocol versions 3 and 4 Seth Forshee
2011-11-07 20:52 ` [PATCH v2 6/7] Input: ALPS - Add semi-MT support for v3 protocol Seth Forshee
2011-11-07 20:52 ` [PATCH v2 7/7] Input: ALPS - Add documentation for protocol versions 3 and 4 Seth Forshee
2011-11-08 3:55 ` [PATCH v2 0/7] Additional ALPS touchpad protocol support Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB84E4F.5020502@canonical.com \
--to=chase.douglas@canonical.com \
--cc=askalski@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rubini@cvml.unipv.it \
--cc=rydberg@euromail.se \
--cc=seth.forshee@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).