From: Chase Douglas <chase.douglas@canonical.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: bump maximum global item tag report size to 96 bytes
Date: Tue, 29 Nov 2011 07:27:38 -0800 [thread overview]
Message-ID: <4ED4F9EA.6030706@canonical.com> (raw)
In-Reply-To: <20111129091713.GA2484@polaris.bitmath.org>
On 11/29/2011 01:17 AM, Henrik Rydberg wrote:
> On Mon, Nov 07, 2011 at 11:08:05AM -0800, Chase Douglas wrote:
>> This allows the latest N-Trig devices to function properly.
>>
>> BugLink: https://bugs.launchpad.net/bugs/724831
>>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Chase Douglas <chase.douglas@canonical.com>
>> ---
>> I have no clue if this is according to spec or not. I only know that this
>> change makes two users' N-Trig devices work properly in the above bug.
>>
>> drivers/hid/hid-core.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/hid/hid-core.c b/drivers/hid/hid-core.c
>> index 848a56c..6113996 100644
>> --- a/drivers/hid/hid-core.c
>> +++ b/drivers/hid/hid-core.c
>> @@ -362,7 +362,7 @@ static int hid_parser_global(struct hid_parser *parser, struct hid_item *item)
>>
>> case HID_GLOBAL_ITEM_TAG_REPORT_SIZE:
>> parser->global.report_size = item_udata(item);
>> - if (parser->global.report_size > 32) {
>> + if (parser->global.report_size > 96) {
>> dbg_hid("invalid report_size %d\n",
>> parser->global.report_size);
>> return -1;
>> --
>> 1.7.5.4
>
> I remember writing this patch as a test, but I never checked the side
> effects. Jiri, perhaps you can enlighten us all on this matter?
Jiri queued this for 3.4, but in the meantime it's queued for the next
Ubuntu 11.10 kernel update. I'll be sure to relay any issues we find
back here.
-- Chase
prev parent reply other threads:[~2011-11-29 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 19:08 [PATCH] HID: bump maximum global item tag report size to 96 bytes Chase Douglas
2011-11-29 9:17 ` Henrik Rydberg
2011-11-29 15:27 ` Chase Douglas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED4F9EA.6030706@canonical.com \
--to=chase.douglas@canonical.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).