From: Jeremy Fitzhardinge <jeremy@goop.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Daniel Nicoletti <dantti12@gmail.com>,
linux-input@vger.kernel.org, vojtech@ucw.cz,
Przemo Firszt <przemo@firszt.eu>,
Richard Hughes <richard@hughsie.com>
Subject: Re: [GIT PULL RFC] directly poll battery strength when reading power_supply
Date: Wed, 07 Dec 2011 17:56:06 -0800 [thread overview]
Message-ID: <4EE01936.70807@goop.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1112061016020.18207@pobox.suse.cz>
On 12/06/2011 01:17 AM, Jiri Kosina wrote:
> On Fri, 2 Dec 2011, Jeremy Fitzhardinge wrote:
>
>> This series of patches includes Daniel's patch to directly poll for the battery strength rather than
>> hoping the device will happen to send it, along with some cleanup patches from me.
>>
>> The only functional change I made from Daniel's patch is keeping the
>> power_supply type as BATTERY rather than USB.
>>
>> J
>>
>> The following changes since commit 1b2bdc70c10f9bf1455ea76a558261d7431b533c:
>>
>> hid-input: add support for HID devices reporting Battery Strength (2011-11-23 00:38:25 -0800)
>>
>> are available in the git repository at:
>> git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git hid-battery
>>
>> Daniel Nicoletti (1):
>> hid-input: add support for HID devices reporting Battery Strength
>>
>> Jeremy Fitzhardinge (7):
>> hid-input: fix compile for !HID_BATTERY_STRENGTH
>> hid-input/battery: remove apparently redundant kmalloc
>> hid-input/battery: add quirks for battery
>> hid-input/battery: deal with both FEATURE and INPUT report batteries
>> hid-input/battery: make the battery setup common for INPUTs and FEATUREs
>> hid-input/battery: power-supply type really *is* a battery
>> hid-input/battery: remove battery_val
> I actually like the series. The only objection I'd have is that Daniel's
> patch is not properly Signed-off-by:, and therefore I am not pulling it
> now.
OK. Daniel, can I add your S-O-B to your patch?
It also seems that it doesn't work with Apple devices yet, so it needs
another iteration or so.
J
next prev parent reply other threads:[~2011-12-08 2:07 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-19 6:52 Supporting Battery Strength from my Bluetooth Mouse Jeremy Fitzhardinge
2011-11-19 11:18 ` Jiri Kosina
2011-11-19 21:34 ` Jeremy Fitzhardinge
2011-11-20 10:26 ` Jiri Kosina
2011-11-21 16:38 ` Jeremy Fitzhardinge
2011-11-21 17:36 ` Dmitry Torokhov
2011-11-21 17:49 ` Jeremy Fitzhardinge
2011-11-21 23:29 ` Jiri Kosina
2011-11-21 23:34 ` Jeremy Fitzhardinge
2011-11-22 0:03 ` Jiri Kosina
2011-11-23 8:49 ` [PATCH RFC] hid-input: add support for HID devices reporting Battery Strength Jeremy Fitzhardinge
2011-11-23 16:36 ` Chase Douglas
2011-11-23 21:07 ` Jeremy Fitzhardinge
2011-11-23 21:52 ` Przemo Firszt
2011-11-28 21:33 ` Jiri Kosina
2011-12-02 5:52 ` Daniel Nicoletti
2011-12-02 17:44 ` Jeremy Fitzhardinge
2011-12-02 18:29 ` Daniel Nicoletti
2011-12-03 6:09 ` Jeremy Fitzhardinge
2011-12-03 6:13 ` [GIT PULL RFC] directly poll battery strength when reading power_supply Jeremy Fitzhardinge
2011-12-06 9:17 ` Jiri Kosina
2011-12-08 1:56 ` Jeremy Fitzhardinge [this message]
2012-05-19 4:10 ` Daniel Nicoletti
2011-12-06 9:56 ` Richard Hughes
2011-12-06 17:10 ` Jeremy Fitzhardinge
2011-12-07 12:51 ` Richard Hughes
2011-12-07 17:25 ` Jeremy Fitzhardinge
2011-12-07 17:29 ` Richard Hughes
2011-12-07 17:36 ` Jeremy Fitzhardinge
2011-12-07 17:41 ` Richard Hughes
2011-12-08 1:41 ` [GIT PULL] power_supply: add power supply scope Jeremy Fitzhardinge
2011-12-08 10:02 ` Anton Vorontsov
2011-12-08 10:05 ` Richard Hughes
2011-12-08 10:42 ` Anton Vorontsov
2011-12-08 10:41 ` Anton Vorontsov
2011-12-08 16:53 ` Jeremy Fitzhardinge
2011-12-08 23:36 ` Anton Vorontsov
2011-12-09 8:18 ` Jeremy Fitzhardinge
2011-12-09 9:59 ` Anton Vorontsov
2011-12-09 16:58 ` Jeremy Fitzhardinge
2011-12-09 10:17 ` Anton Vorontsov
2011-12-09 17:49 ` Jeremy Fitzhardinge
2011-12-09 20:00 ` Daniel Nicoletti
2011-12-09 20:36 ` Jeremy Fitzhardinge
2011-12-02 17:58 ` [PATCH RFC] hid-input: add support for HID devices reporting Battery Strength Jeremy Fitzhardinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE01936.70807@goop.org \
--to=jeremy@goop.org \
--cc=dantti12@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=przemo@firszt.eu \
--cc=richard@hughsie.com \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).