From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeremy Fitzhardinge Subject: Re: [GIT PULL RFC] directly poll battery strength when reading power_supply Date: Wed, 07 Dec 2011 17:56:06 -0800 Message-ID: <4EE01936.70807@goop.org> References: <4EC75224.7070207@goop.org> <4EC820F8.4070900@goop.org> <4ECA7E7D.80207@goop.org> <4ECAE019.4000409@goop.org> <4ECCB38A.8000503@goop.org> <4ED90E6D.8090402@goop.org> <4ED9BDF8.3010600@goop.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from claw.goop.org ([74.207.240.146]:58610 "EHLO claw.goop.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756792Ab1LHCHC (ORCPT ); Wed, 7 Dec 2011 21:07:02 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Daniel Nicoletti , linux-input@vger.kernel.org, vojtech@ucw.cz, Przemo Firszt , Richard Hughes On 12/06/2011 01:17 AM, Jiri Kosina wrote: > On Fri, 2 Dec 2011, Jeremy Fitzhardinge wrote: > >> This series of patches includes Daniel's patch to directly poll for the battery strength rather than >> hoping the device will happen to send it, along with some cleanup patches from me. >> >> The only functional change I made from Daniel's patch is keeping the >> power_supply type as BATTERY rather than USB. >> >> J >> >> The following changes since commit 1b2bdc70c10f9bf1455ea76a558261d7431b533c: >> >> hid-input: add support for HID devices reporting Battery Strength (2011-11-23 00:38:25 -0800) >> >> are available in the git repository at: >> git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git hid-battery >> >> Daniel Nicoletti (1): >> hid-input: add support for HID devices reporting Battery Strength >> >> Jeremy Fitzhardinge (7): >> hid-input: fix compile for !HID_BATTERY_STRENGTH >> hid-input/battery: remove apparently redundant kmalloc >> hid-input/battery: add quirks for battery >> hid-input/battery: deal with both FEATURE and INPUT report batteries >> hid-input/battery: make the battery setup common for INPUTs and FEATUREs >> hid-input/battery: power-supply type really *is* a battery >> hid-input/battery: remove battery_val > I actually like the series. The only objection I'd have is that Daniel's > patch is not properly Signed-off-by:, and therefore I am not pulling it > now. OK. Daniel, can I add your S-O-B to your patch? It also seems that it doesn't work with Apple devices yet, so it needs another iteration or so. J