From: Simon Budig <simon.budig@kernelconcepts.de>
To: Anatolij Gustschin <agust@denx.de>
Cc: linux-input@vger.kernel.org, dmitry.torokhov@gmail.com,
Ilya Yanok <yanok@emcraft.com>
Subject: Re: [PATCH v2] Touchscreen driver for FT5x06 based EDT displays
Date: Thu, 15 Dec 2011 12:00:03 +0100 [thread overview]
Message-ID: <4EE9D333.8050107@kernelconcepts.de> (raw)
In-Reply-To: <20111202145146.33d5b8be@wker>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Anatolij.
On 12/02/2011 02:51 PM, Anatolij Gustschin wrote:
> there is a number of issues with this patch. Please check it
> using 'scripts/checkpatch.pl' and fix them before posting next
> patch version. Thanks! Please see a comment below.
Ok, There are a lot of warnings/errors regarding my use of spaces for
alignment of multi-line function calls.
(i.e. use tabs for the logical indentation level plus spaces to align
e.g. function arguments behind the opening parenthesis)
<tab><tab>function (argument1,
<tab><tab> argument2);
This has the advantage of not breaking alignment when changing tab
width. Is this something acceptable in the kernel? It seems CodingStyle
is open to interpretation there, not sure if the conding style is open
for discussion though... :)
Or should I just globally replace 8 subsequent spaces with a tab?
> passing platform data for specifying reset_pin should be optional,
> I think. There are hardware configurations without wired gpio for
> /RST controlling, /RST is controlled by HW-circuitry. The driver
> should be usable with such configurations, too. Can you please
> change the driver so that controlling reset pin becomes optional?
Will do.
Thanks,
Simon
- --
Simon Budig kernel concepts GmbH
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAk7p0zMACgkQO2O/RXesiHBbqQCglB7P11riuVoM1pKQ7CLRusmP
uMYAnRWclP+LLcKWmwvndvm38V1BoK1T
=wmrp
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2011-12-15 11:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-29 15:52 [PATCH v2] Touchscreen driver for FT5x06 based EDT displays Simon Budig
2011-09-29 15:52 ` Simon Budig
2011-12-02 13:51 ` Anatolij Gustschin
2011-12-15 11:00 ` Simon Budig [this message]
2011-12-15 12:17 ` agust
2011-12-15 13:41 ` Simon Budig
2011-12-16 11:51 ` Anatolij Gustschin
2011-12-20 22:47 ` Ilya Yanok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE9D333.8050107@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=agust@denx.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=yanok@emcraft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).