From: Chase Douglas <chase.douglas@canonical.com>
To: Henrik Rydberg <rydberg@euromail.se>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jussi Pakkanen <jussi.pakkanen@canonical.com>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v3] bcm5974: Set BUTTONPAD property
Date: Wed, 11 Jan 2012 11:09:18 +0100 [thread overview]
Message-ID: <4F0D5FCE.6080809@canonical.com> (raw)
In-Reply-To: <20120111100444.GA5573@polaris.bitmath.org>
On 01/11/2012 11:04 AM, Henrik Rydberg wrote:
>>> Applied, however I removed stable notation as this change IMO does not
>>> qualify for the stable since it does not address a regression.
>>
>> It's not a regression per-se, but we want to fix buttonpad support, and
>> we can't do that without this patch. It's a clear bug that when the
>> property was added we did not set the property in the devices that need it.
>
> The current behavior depends on userspace and is not a kernel bug,
> please stop the nonsense already.
>
> For bcm5974 devices, extracting buttonpad properties has been possible
> since early 2009 (158e9287). The mechanism, predating the input
> properties interface by nearly two years, has been used in the
> multitouch and mtrack X drivers ever since. To those users, the
> present patch has no effect at all.
Just because an alternative interface has existed does not mean there
isn't a bug. A device that has a physical property, but does not set the
property bit in the driver is a real bug that needs to be fixed.
Userspace should not have to quirk around broken implementations.
It's true that userspace can quirk around things in a kernel that
predates the property bits, but where the property bits are available
the devices *must* set them or else things will break.
-- Chase
next prev parent reply other threads:[~2012-01-11 10:09 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-10 9:36 [PATCH] Set buttonpad property on those bcm5974 devices that have a physical button Jussi Pakkanen
2012-01-10 9:45 ` Henrik Rydberg
2012-01-10 10:08 ` [PATCH v2] " Jussi Pakkanen
2012-01-10 10:22 ` Henrik Rydberg
2012-01-10 10:56 ` [PATCH v3] bcm5974: Set BUTTONPAD property Jussi Pakkanen
2012-01-10 11:42 ` Henrik Rydberg
2012-01-11 7:38 ` Dmitry Torokhov
2012-01-11 9:23 ` Chase Douglas
2012-01-11 10:04 ` Henrik Rydberg
2012-01-11 10:09 ` Chase Douglas [this message]
2012-01-11 17:18 ` Dmitry Torokhov
2012-01-11 21:36 ` Chase Douglas
2012-01-11 21:59 ` Dmitry Torokhov
2012-01-11 22:57 ` Chase Douglas
2012-01-12 0:22 ` Henrik Rydberg
2012-01-12 10:19 ` Chase Douglas
2012-01-17 16:39 ` Chase Douglas
2012-01-17 18:06 ` Dmitry Torokhov
2012-01-17 18:15 ` Henrik Rydberg
2012-01-17 18:24 ` Jason Gerecke
2012-01-17 19:21 ` Dmitry Torokhov
2012-01-17 20:27 ` Jason Gerecke
2012-01-17 20:40 ` Dmitry Torokhov
2012-01-17 21:10 ` Jason Gerecke
2012-01-17 18:25 ` Chase Douglas
2012-01-17 18:57 ` Henrik Rydberg
2012-01-17 19:06 ` Chase Douglas
2012-01-17 19:29 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F0D5FCE.6080809@canonical.com \
--to=chase.douglas@canonical.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jussi.pakkanen@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=rydberg@euromail.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).