Re: [PATCH 2/2] Input/spear-keyboard: Provide thaw and poweroff routines

[Shubhrajyoti <shubhrajyoti@ti.com>]

On Thursday 23 February 2012 05:26 PM, Viresh Kumar wrote:
> On 2/23/2012 4:59 PM, Shubhrajyoti wrote:
>>>> - Using test features, of hibernate.
>> Not a comment doubt
>>
>> When is thaw called and when is power off called?
> Firstly freeze is called, after that snapshot of memory is taken
> (to be saved in disk). Now, we need resume harddisk, so we get our
> thaw routines called (analogous to resume). Now system is up again. Save
> image to disk and call poweroff() to finally shutdown.
>
> Refer Documentation/power/devices.txt to get complete sequence of calls.
Makes sense thanks.
>>>> diff --git a/drivers/input/keyboard/spear-keyboard.c b/drivers/input/keyboard/spear-keyboard.c
>>>> index 6eb2dd8..6e83828 100644
>>>> --- a/drivers/input/keyboard/spear-keyboard.c
>>>> +++ b/drivers/input/keyboard/spear-keyboard.c
>>>> @@ -321,10 +321,7 @@ static int spear_kbd_resume(struct device *dev)
>>>>  	return 0;
>>>>  }
>>>>  
>>>> -static const struct dev_pm_ops spear_kbd_pm_ops = {
>>>> -	.suspend	= spear_kbd_suspend,
>>>> -	.resume		= spear_kbd_resume,
>>>> -};
>> Now that you have converted to simple dev pm can you remove the #ifdef
>> from pm.
>>
> I didn't get it completely. CONFIG_PM Macro's are still required.
The dev pm makes it empty so not required.