From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 12/20] Input: atmel_mxt_ts - simplify event reporting Date: Tue, 20 Mar 2012 08:13:35 -0700 Message-ID: <4F689E9F.90902@itdev.co.uk> References: <1331640263-18935-1-git-send-email-djkurtz@chromium.org> <1331640263-18935-13-git-send-email-djkurtz@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from [89.21.227.130] ([89.21.227.130]:40576 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1755043Ab2CTPNj (ORCPT ); Tue, 20 Mar 2012 11:13:39 -0400 In-Reply-To: <1331640263-18935-13-git-send-email-djkurtz@chromium.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Daniel Kurtz Cc: Dmitry Torokhov , Joonyoung Shim , Iiro Valkonen , Henrik Rydberg , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen , "Bowens, Alan" , "Tiwari, Atul" Daniel Kurtz wrote: > Instead of carrying around per-finger state in the driver instance, just > report each finger as it arrives to the input layer, and let the input > layer (evdev) hold the event state (which it does anyway). > > Also, the atmel pad reports "amplitude", which is reported to userspace > using the "PRESSURE" event type. The variables now reflect this. > > Note: this driver does not really do MT-B properly. Each input report > (a goup of input events followed by a SYN_REPORT) only contains data for > a single contact. When multiple fingers are present on a device, each is > properly reported in its own MT_SLOT. However, there is only ever one > MT_SLOT per SYN_REPORT. This is fixed in a subsequent patch. > > Signed-off-by: Daniel Kurtz This seems to be a good improvement, assuming it is valid. Which platforms have you tested it on? -- Nick Dyer Software Engineer, ITDev Ltd Hardware and Software Development Consultancy Website: http://www.itdev.co.uk