From: Nikolai Kondrashov <spbnick@gmail.com>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-input <linux-input@vger.kernel.org>
Subject: Re: [PATCH 1/1] HID: add have_special_driver hid module parameter
Date: Sun, 01 Apr 2012 23:50:10 +0300 [thread overview]
Message-ID: <4F78BF82.70903@gmail.com> (raw)
In-Reply-To: <alpine.LNX.2.00.1204012137150.16928@pobox.suse.cz>
On 04/01/2012 10:46 PM, Jiri Kosina wrote:
> On Sun, 1 Apr 2012, Nikolai Kondrashov wrote:
>> 1. The HID report descriptor is parsed only once, on first device probe and
>> the resulting data is kept within device structure. It is not parsed
>> again after unbind/bind, thus report_fixup of my driver is not called and
>> the reports are getting interpreted according to the old one, rendering
>> the device (partially) unusable.
>
> Hmm, you are absolutely right. This is the thing we should fix first,
> instead of introducing more-or-less hackish workarounds.
I agree. It's just I didn't think I could fix it quickly and didn't expect
anyone to be interested in fixing it for me. Thus, I proposed accepting this
solution for now.
> I will be travelling for the whole day tomorrow, so I will look into this
> onboard the airplane and will try to come up with a fix.
Great! Thank you :)!
>> 2. The udev rules and scripts needed to make it work in a plug'n'play manner
>> suitable for users are considerably more hacky than this solution.
>
> As this is solely for the purpose of out-of-tree drivers, I believe it's
> better to keep the hackery in userspace though.
I tend to agree. After all, decision on which module to load lies on
userspace, so it might as well decide which one to use. Anyway, I haven't
implemented it fully yet and am still to see if it's really that bad.
>> I'd like to ask you to accept this patch for now. Would it still be
>> possible to get this patch into 3.4? I promise to look for a better
>> solution. First step would probably be to fix rebinding.
>
> Let's see whether we can come up with proper rebinding fix quickly enough.
> I don't want to end up introducing module parameter that we don't need, as
> we'll have to be maintaining it for compatibility reasons forever.
Sure. I must admit, I didn't think about maintaining the compatibility,
sorry.
>> It seems that you don't have much time recently to review/accept my patches.
>> Would you direct me to someone else who could do this and thus reduce your
>> load?
>
> It's just a matter of prioritizing the incoming queue. I believe I process
> your new drivers and support for new devices by in-tree drivers in a
> timely manner.
Sorry, I didn't mean to complain. It's just we didn't get to discuss this
patch properly until more than a month after I submitted it and then the
Waltop Sirius patch didn't make it into 3.4, so I thought maybe I'm not
supposed to send everything to you and there is some other way.
Thank you for reviewing my patches all this time.
> But this is a core infrastructure change, influencing how we aproach
> out-of-tree drivers, so we'd better be sure to get it right before
> merging (even more so as your solution introduces a userspace interface
> (module parameter) that we'll have to keep forever).
I agree.
Thank you.
Sincerely,
Nick
next prev parent reply other threads:[~2012-04-01 20:50 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-20 21:29 [PATCH 1/1] HID: add have_special_driver hid module parameter Nikolai Kondrashov
2012-02-27 14:15 ` Nikolai Kondrashov
2012-02-28 14:30 ` Jiri Kosina
2012-02-28 15:12 ` Nikolai Kondrashov
2012-02-29 21:23 ` Nikolai Kondrashov
2012-03-29 8:00 ` Nikolai Kondrashov
2012-03-30 13:49 ` Jiri Kosina
2012-03-30 15:22 ` Nikolai Kondrashov
2012-03-30 23:03 ` David Herrmann
2012-04-01 19:44 ` Nikolai Kondrashov
2012-04-01 19:49 ` Jiri Kosina
2012-04-01 20:11 ` Nikolai Kondrashov
2012-04-01 20:10 ` David Herrmann
2012-04-01 20:22 ` Nikolai Kondrashov
2012-04-01 19:33 ` Nikolai Kondrashov
2012-04-01 19:46 ` Jiri Kosina
2012-04-01 20:50 ` Nikolai Kondrashov [this message]
2012-04-02 23:41 ` Jiri Kosina
2012-04-04 8:27 ` Nikolai Kondrashov
2012-04-08 10:48 ` Nikolai Kondrashov
2012-04-03 14:46 ` Henrik Rydberg
2012-04-03 15:09 ` Jiri Kosina
2012-04-03 16:37 ` Henrik Rydberg
2012-04-03 17:01 ` Jiri Kosina
2012-04-03 17:11 ` Henrik Rydberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F78BF82.70903@gmail.com \
--to=spbnick@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).