From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Warren Subject: Re: [PATCHv3 1/2] drivers: input: keypad: Add device tree support Date: Mon, 23 Apr 2012 09:26:22 -0600 Message-ID: <4F95749E.40708@wwwdotorg.org> References: <1335194839-30193-1-git-send-email-sourav.poddar@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from avon.wwwdotorg.org ([70.85.31.133]:44640 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751579Ab2DWP01 (ORCPT ); Mon, 23 Apr 2012 11:26:27 -0400 In-Reply-To: <1335194839-30193-1-git-send-email-sourav.poddar@ti.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Sourav Poddar Cc: devicetree-discuss@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, Benoit Cousson , Rob Herring , Grant Likely , Felipe Balbi , Dmitry Torokhov , Randy Dunlap On 04/23/2012 09:27 AM, Sourav Poddar wrote: > Update the Documentation with omap4 keypad device tree > binding information. > Add device tree support for omap4 keypad driver. Shouldn't this use the already-defined matrix keyboard bindings at Documentation/devicetree/bindings/input/matrix-keymap.txt? (I asked this before, but don't recall seeing any response explaining why a new binding was needed. Sorry if I missed it.)