From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 09/14 v3] Input: atmel_mxt_ts - refactor get info Date: Sat, 05 May 2012 18:41:49 +0100 Message-ID: <4FA5665D.80304@itdev.co.uk> References: <1334755319-21365-1-git-send-email-djkurtz@chromium.org> <1334755319-21365-10-git-send-email-djkurtz@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from [89.21.227.130] ([89.21.227.130]:42410 "EHLO mail.epsilon.itdev.co.uk" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756487Ab2EERwQ (ORCPT ); Sat, 5 May 2012 13:52:16 -0400 In-Reply-To: <1334755319-21365-10-git-send-email-djkurtz@chromium.org> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Daniel Kurtz Cc: Dmitry Torokhov , Henrik Rydberg , Joonyoung Shim , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Benson Leung , Yufeng Shen Hi Daniel- Daniel Kurtz wrote: > - dev_info(&client->dev, > - "Family ID: %d Variant ID: %d Version: %d Build: %d\n", > - info->family_id, info->variant_id, info->version, > - info->build); > + dev_info(dev, "Family ID: %d Variant ID: %d Major.Minor.Build: %d.%d.%d\n", > + info->family_id, info->variant_id, info->version >> 4, > + info->version & 0xf, info->build); The canonical format for the Atmel firmware versions has the build number in hex, eg. 2.0.AA So it should be %d.%d.%02X cheers Nick