From: Peter Ujfalusi <peter.ujfalusi@ti.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Sasha Levin <levinsasha928@gmail.com>,
dmitry.torokhov@gmail.com, broonie@opensource.wolfsonicro.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] TWL6040: fix build error
Date: Fri, 11 May 2012 15:16:39 +0300 [thread overview]
Message-ID: <4FAD0327.7040305@ti.com> (raw)
In-Reply-To: <CACxGe6vbn7r10KT-q2GGtJatv12prE4ZFJxWsSzPEyLoCuH27A@mail.gmail.com>
On 05/11/2012 07:27 AM, Grant Likely wrote:
> On Thu, May 10, 2012 at 4:49 PM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> On Thu, May 10, 2012 at 2:44 PM, Sasha Levin <levinsasha928@gmail.com> wrote:
>>> Fixes build error due to missing of_property_read_u32.
>>
>> Yes, I saw the same on x86-64 allyesconfig -- which means that in addition to
>> this missing header, it needs to have a Kconfig dependency that limits
>> it to just being enabled on the platforms where it physically is possible to
>> have the hardware. I'm guessing limiting to ARM would be a good start?
>
> IIRC, this hardware is available on x86. Also, if CONFIG_OF is not
> set, then the of_property_read_* functions compile out to do-nothing
> stubs.
I had only linux/of_device.h included which would include of.h only if
CONFIG_OF_DEVICE is set.
Since the i386 did not had OF_DEVICE the of.h was not included (by
of_device.h) thus caused a build breakage.
--
Péter
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-05-11 12:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-10 18:44 [PATCH] TWL6040: fix build error Sasha Levin
2012-05-10 22:49 ` Paul Gortmaker
2012-05-11 2:50 ` Sasha Levin
2012-05-11 2:58 ` Paul Gortmaker
2012-05-11 4:27 ` Grant Likely
2012-05-11 12:16 ` Peter Ujfalusi [this message]
2012-05-11 7:03 ` Peter Ujfalusi
2012-05-11 7:20 ` Dmitry Torokhov
2012-05-11 14:03 ` Paul Gortmaker
2012-05-11 15:05 ` Peter Ujfalusi
2012-05-11 15:49 ` Dmitry Torokhov
2012-05-11 16:10 ` Paul Gortmaker
2012-05-13 10:53 ` Mark Brown
2012-05-11 4:03 ` Dmitry Torokhov
2012-05-11 6:58 ` Peter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FAD0327.7040305@ti.com \
--to=peter.ujfalusi@ti.com \
--cc=broonie@opensource.wolfsonicro.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=levinsasha928@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul.gortmaker@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).