From: Bo Shen <voice.shen@atmel.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Josh Wu <josh.wu@atmel.com>,
javier.martin@vista-silicon.com, khali@linux-fr.org,
w.sang@pengutronix.de, jm.lin@atmel.com,
linux-input@vger.kernel.org
Subject: Re: [RFC] QT1070: change the trigger mode of QT1070
Date: Mon, 14 May 2012 10:54:30 +0800 [thread overview]
Message-ID: <4FB073E6.8070303@atmel.com> (raw)
In-Reply-To: <20120511160846.GC6542@core.coreip.homeip.net>
On 5/12/2012 0:08, Dmitry Torokhov wrote:
> On Fri, May 11, 2012 at 04:28:22PM +0800, Josh Wu wrote:
>> Hello, Dmitry
>>
>> On 5/7/2012 3:04 PM, Dmitry Torokhov wrote:
>>> Hi Bo,
>>>
>>> On Mon, May 07, 2012 at 10:27:33AM +0800, Bo Shen wrote:
>>>> The default trigger mode of QT1070 is IRQF_TRIGGER_LOW,
>>>> Using TRQF_TRIGGER_FALLING to replace IRQF_TRIGGER_LOW | IRQF_ONESHOT.
>>> Why don't you set up IRQ the way you want in board code instead of
>>> implementing workarounds in the driver?
>> The QT1070 will generate a falling edge interrupt if any valid data
>> coming. The workaround is only for the boarding that can handle edge
>> interrupt but cannot distinguish rising and falling.
>> So I think put this trigger set up code to board code will make
>> thing more complex.
> In the board code it is only a matter of doing irq_set_irq_type(). AT
> this time you know exactly how chip is wired and whether it needs level
> or edge interupts.
Hi Dmitry,
Thanks, this API works fine. So, there is no need to change the
driver code of QT1070.
> Thanks.
>
next prev parent reply other threads:[~2012-05-14 2:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-07 2:27 [RFC] QT1070: change the trigger mode of QT1070 Bo Shen
2012-05-07 7:04 ` Dmitry Torokhov
2012-05-07 7:09 ` javier Martin
2012-05-08 7:45 ` Shen, Voice
2012-05-11 8:28 ` Josh Wu
2012-05-11 9:13 ` javier Martin
2012-05-11 11:33 ` Josh Wu
2012-05-11 12:47 ` javier Martin
2012-05-14 2:57 ` Bo Shen
2012-05-14 6:59 ` javier Martin
2012-05-14 7:21 ` javier Martin
2012-05-11 16:06 ` Dmitry Torokhov
2012-05-11 16:08 ` Dmitry Torokhov
2012-05-14 2:54 ` Bo Shen [this message]
2012-05-11 8:07 ` Josh Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB073E6.8070303@atmel.com \
--to=voice.shen@atmel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=javier.martin@vista-silicon.com \
--cc=jm.lin@atmel.com \
--cc=josh.wu@atmel.com \
--cc=khali@linux-fr.org \
--cc=linux-input@vger.kernel.org \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).