From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C09E65F872 for ; Mon, 29 Jan 2024 11:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706526644; cv=none; b=VZ0zotPrk2mDHE8gKgwkyxZE7aNE20a/1mixBvcfT2zT+SRMdX7hClS+y8hrZHRLJsNs5XVqaqe08OQAdmY3E9SAMPbN7Pvl8bClMQv+8E80ttfZFZ4m9h7H6t+naFQDsSeFV0A5Fmq+Gs4nekfqDh3U4yMQBkD7vXc0nBlTxKw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706526644; c=relaxed/simple; bh=iCt3ARyPFGaFcNNh6hPSDnvIq7kLiJZCIOO0G1SZ8xM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=KrTwHHPi6bfGov8xE/iKWkY2JP2iH0LjmCuNNa0lUqHWg4iXlqIsBW6x/z3pw5kS3mGkDGD2prX11GSwdy41TfSkXWprPF4dkxqxYEr64aqv3QqvH6UnFWnTarT3nzRhVjE9UzsNT2TqkV2wj0cxOl+aHMXSSNPAOWmFu79AQOI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=f42a5kof; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="f42a5kof" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706526641; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VViNKQmytjZMa9HQwAlRrm1lQV2U6Y/HrJkRvfH9jxI=; b=f42a5kofjjL76NJRQGCmjtK4L9TAU+IAF1vfgLjkMBDsj/Wr0gc+5sgarw2Ukcwy8EjSaV kBpTR/2R0Wrp+LQ/2iS0jIlEHULhgSJfCQuNxgS3tqgmOmx6LhFfFlIRsjbbafKxiqk/n7 pIa/Ehd/RzzUsKrvMjUyeYbY0kumV64= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-274-S58iBaRWN9uc_Lz8sqxpiw-1; Mon, 29 Jan 2024 06:10:40 -0500 X-MC-Unique: S58iBaRWN9uc_Lz8sqxpiw-1 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-a2b068401b4so291382666b.1 for ; Mon, 29 Jan 2024 03:10:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706526639; x=1707131439; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VViNKQmytjZMa9HQwAlRrm1lQV2U6Y/HrJkRvfH9jxI=; b=u8tj4d/zCYjLocD3pjkMuyVmsU/TmkiDQNCxu/YqoO2TiDqtCIDqHFY9LE+hOYa1EX jqLWx8cM0CLPiZ1ZVpyBx7A/G0gUt8hVDMGXDIerGeekqz3e7A4W6tE1Z176E6mTcWgz au6ltKX7wTxJkdmSHuz6/qCJdH1VJdDp7xQc44GWZ6jzyOZv6EDm0aM8NGo7NMmXgxvr SwIzH1UzqakT/z8Bec0SJkx6hPVd+bnPK9cQIpaq75B05iPQ3ONENghzOoEqExU4471g 4GiMDN0pH/zsdI74sS9knAecTin9IAbuyepVjJvCOQYJQk+StzQynBuJeUNUoziZcjtF UTEg== X-Gm-Message-State: AOJu0YwTyH6TvBR4K35lEeu3XjFIAH/gQcFWHPxNBt0y7WMXfStm7MD9 ihBk9pF1A8FLp1PyIkpjynjQ8DNEVy4fgy5dvsylKGE8T/9wh0rbXZA3hjU+uE59C4hsDcdRFaD hT+pjAx/e71KyQPaCGtyISMJlpi9SnYTdQbQ0OlaD6pwtQbP//lx/zZbp64qd X-Received: by 2002:a17:906:3691:b0:a2f:dae6:5987 with SMTP id a17-20020a170906369100b00a2fdae65987mr7350006ejc.33.1706526639087; Mon, 29 Jan 2024 03:10:39 -0800 (PST) X-Google-Smtp-Source: AGHT+IHcHk7VsGGZmyJ31XzDUOwX/PEXGRkxnSxZgRRLBV6kLpC49QOXF5mRcEpT4h1mjOw9NQdpLQ== X-Received: by 2002:a17:906:3691:b0:a2f:dae6:5987 with SMTP id a17-20020a170906369100b00a2fdae65987mr7349995ejc.33.1706526638797; Mon, 29 Jan 2024 03:10:38 -0800 (PST) Received: from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec? (2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl. [2001:1c00:c32:7800:5bfa:a036:83f0:f9ec]) by smtp.gmail.com with ESMTPSA id cu2-20020a170906ba8200b00a35757cbd9esm1944925ejd.4.2024.01.29.03.10.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 03:10:37 -0800 (PST) Message-ID: <4c68a68f-5fc6-4906-b958-4e2bd8fcd25a@redhat.com> Date: Mon, 29 Jan 2024 12:10:37 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Flood of logitech-hidpp-device messages in v6.7 Content-Language: en-US, nl To: Jiri Kosina Cc: Oleksandr Natalenko , linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, =?UTF-8?Q?Filipe_La=C3=ADns?= , Bastien Nocera , Benjamin Tissoires References: <3277085.44csPzL39Z@natalenko.name> <824573bb-ae01-41b9-8f97-a760ae8f3f18@redhat.com> From: Hans de Goede In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Jiri, On 1/17/24 20:01, Jiri Kosina wrote: > On Tue, 9 Jan 2024, Hans de Goede wrote: > >>> Jan 09 10:05:06 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: Disconnected >>> Jan 09 10:07:15 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: Disconnected >>> Jan 09 10:16:51 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: HID++ 4.5 device connected. >>> Jan 09 10:16:55 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 10:16:55 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 10:36:31 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: Disconnected >>> Jan 09 10:37:07 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: HID++ 4.5 device connected. >>> Jan 09 10:46:21 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: Disconnected >>> Jan 09 10:48:23 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: Disconnected >>> Jan 09 11:12:27 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: HID++ 4.5 device connected. >>> Jan 09 11:12:47 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 11:12:47 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 11:38:32 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: Disconnected >>> Jan 09 11:43:32 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: Disconnected >>> Jan 09 11:45:10 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: HID++ 4.5 device connected. >>> Jan 09 11:45:11 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 11:45:11 spock kernel: logitech-hidpp-device 0003:046D:408A.0005: HID++ 4.5 device connected. >>> Jan 09 12:31:48 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: Disconnected >>> Jan 09 12:33:21 spock kernel: logitech-hidpp-device 0003:046D:4051.0006: HID++ 4.5 device connected. >>> ``` >>> >>> I've got the following hardware: >>> >>> * Bus 006 Device 004: ID 046d:c52b Logitech, Inc. Unifying Receiver >>> * Logitech MX Keys >>> * Logitech M510v2 >>> >>> With v6.6 I do not get those messages. >>> >>> I think this is related to 680ee411a98e ("HID: logitech-hidpp: Fix connect event race"). >>> >>> My speculation is that some of the devices enter powersaving state after being idle for some time (5 mins?), and then wake up and reconnect once I touch either keyboard or mouse. I should highlight that everything works just fine, it is the flood of messages that worries me. >>> >>> Is it expected? >> >> Yes this is expected, looking at your logs I see about 10 messages per >> hour which IMHO is not that bad. >> >> I guess we could change things to track we have logged the connect >> message once and if yes then log future connect messages (and all >> disconnect messages) at debug level. >> >> Jiri, Benjamin, do you have any opinion on this ? > > Works for me, thanks. Do you plan to submit the patch implementing this? I was planning too, but I'm a bit swamped atm. I would not mind someone else implementing this suggestion and I would be happy to review and test. Regards, Hans