From: "Kim Kyuwon" <chammoru@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Jiri Kosina <jkosina@suse.cz>,
linux-input@vger.kernel.org, sj76.park@samsung.com,
sk.heo@samsung.com, kyungmin.park@samsung.com
Subject: Re: Adding 'half shutter' definition to 'input.h'
Date: Mon, 12 Jan 2009 10:00:32 +0900 [thread overview]
Message-ID: <4d34a0a70901111700g4b2ccc6fme6cfcf7aa32b46fa@mail.gmail.com> (raw)
In-Reply-To: <20090110235337.ZZRA012@mailhub.coreip.homeip.net>
Hi, Dmitry,
On Sun, Jan 11, 2009 at 4:57 PM, Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> Hi Kim, Jiri,
>
> On Thu, Jan 08, 2009 at 09:51:11AM +0100, Jiri Kosina wrote:
>> On Thu, 8 Jan 2009, Kim Kyuwon wrote:
>>
>> > Because Jiri Kosina personally agrees with adding the [half]shutter key
>> > yesterday, I'm sending this patch. (Thanks Jiri)
>> > New cameras and mobile phones (at least SAMSUNG's) have the half shutter for
>> > 'auto-focus' functions. so I think this half and full shutter keys are needed.
>> > Please review this patch.
>>
>> Hi,
>>
>> please note the "if there is any in-kernel code that actually uses it"
>> part of my e-mail. Adding just the key definition without any kernel code
>> actually using is not likely to happen.
>>
>
> Additionally I don't think we need 2 new codes. We have KEY_CAMERA that
> is supposed to be sent when we want to take the picture, so only one new
> is needed. Probably should call it KEY_FOCUS or KEY_CAMERA_FOCUS.
>
> --
> Dmitry
>
OK, It seems like your suggestion is better mine :)
(Personally I prefer KEY_FOCUS to KEY_CAMERA_FOCUS )
And I would be really satisfied, if any key which can represent the half
shutter is added to 'input.h'
Thank you for thinking this issue again.
If there are further steps that I can take, please let me know.
--
Kim Kyuwon
next prev parent reply other threads:[~2009-01-12 1:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <13840250.309261230013670370.JavaMail.weblogic@epml09>
[not found] ` <200812230045.42765.dmitry.torokhov@gmail.com>
[not found] ` <4d34a0a70812231631u359e85an29d2ed30bccd59a5@mail.gmail.com>
2009-01-08 2:48 ` Adding 'half shutter' definition to 'input.h' Kim Kyuwon
2009-01-08 8:51 ` Jiri Kosina
2009-01-11 7:57 ` Dmitry Torokhov
2009-01-12 1:00 ` Kim Kyuwon [this message]
2009-01-12 7:23 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d34a0a70901111700g4b2ccc6fme6cfcf7aa32b46fa@mail.gmail.com \
--to=chammoru@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=kyungmin.park@samsung.com \
--cc=linux-input@vger.kernel.org \
--cc=sj76.park@samsung.com \
--cc=sk.heo@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).