From: srinivas pandruvada <srinivas.pandruvada@linux.intel.com>
To: Ye Xiang <xiang.ye@intel.com>, jikos@kernel.org, jic23@kernel.org
Cc: linux-input@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL
Date: Fri, 17 Dec 2021 04:33:07 -0800 [thread overview]
Message-ID: <4d8308f4a3249b662536371e14e6cd6ef723f5a9.camel@linux.intel.com> (raw)
In-Reply-To: <20211217074541.4705-1-xiang.ye@intel.com>
On Fri, 2021-12-17 at 15:45 +0800, Ye Xiang wrote:
> Specify that both TGL and ADL don't support DMA cache snooping.
>
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct
> ishtp_device *dev, int length,
> */
> static bool _dma_no_cache_snooping(struct ishtp_device *dev)
> {
> - return dev->pdev->device == EHL_Ax_DEVICE_ID;
> + return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> + dev->pdev->device == TGL_LP_DEVICE_ID ||
> + dev->pdev->device == TGL_H_DEVICE_ID ||
> + dev->pdev->device == ADL_S_DEVICE_ID ||
> + dev->pdev->device == ADL_P_DEVICE_ID);
> }
>
> static const struct ishtp_hw_ops ish_hw_ops = {
next prev parent reply other threads:[~2021-12-17 12:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 7:45 [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL Ye Xiang
2021-12-17 12:33 ` srinivas pandruvada [this message]
2022-01-06 13:18 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4d8308f4a3249b662536371e14e6cd6ef723f5a9.camel@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=jic23@kernel.org \
--cc=jikos@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xiang.ye@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).