* [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL
@ 2021-12-17 7:45 Ye Xiang
2021-12-17 12:33 ` srinivas pandruvada
2022-01-06 13:18 ` Jiri Kosina
0 siblings, 2 replies; 3+ messages in thread
From: Ye Xiang @ 2021-12-17 7:45 UTC (permalink / raw)
To: jikos, jic23, srinivas.pandruvada
Cc: linux-input, linux-iio, linux-kernel, Ye Xiang
Specify that both TGL and ADL don't support DMA cache snooping.
Signed-off-by: Ye Xiang <xiang.ye@intel.com>
---
drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
index 45e0c7b1c9ec..8ccb246b0114 100644
--- a/drivers/hid/intel-ish-hid/ipc/ipc.c
+++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
@@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
*/
static bool _dma_no_cache_snooping(struct ishtp_device *dev)
{
- return dev->pdev->device == EHL_Ax_DEVICE_ID;
+ return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
+ dev->pdev->device == TGL_LP_DEVICE_ID ||
+ dev->pdev->device == TGL_H_DEVICE_ID ||
+ dev->pdev->device == ADL_S_DEVICE_ID ||
+ dev->pdev->device == ADL_P_DEVICE_ID);
}
static const struct ishtp_hw_ops ish_hw_ops = {
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL
2021-12-17 7:45 [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL Ye Xiang
@ 2021-12-17 12:33 ` srinivas pandruvada
2022-01-06 13:18 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: srinivas pandruvada @ 2021-12-17 12:33 UTC (permalink / raw)
To: Ye Xiang, jikos, jic23; +Cc: linux-input, linux-iio, linux-kernel
On Fri, 2021-12-17 at 15:45 +0800, Ye Xiang wrote:
> Specify that both TGL and ADL don't support DMA cache snooping.
>
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-
> ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct
> ishtp_device *dev, int length,
> */
> static bool _dma_no_cache_snooping(struct ishtp_device *dev)
> {
> - return dev->pdev->device == EHL_Ax_DEVICE_ID;
> + return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> + dev->pdev->device == TGL_LP_DEVICE_ID ||
> + dev->pdev->device == TGL_H_DEVICE_ID ||
> + dev->pdev->device == ADL_S_DEVICE_ID ||
> + dev->pdev->device == ADL_P_DEVICE_ID);
> }
>
> static const struct ishtp_hw_ops ish_hw_ops = {
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL
2021-12-17 7:45 [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL Ye Xiang
2021-12-17 12:33 ` srinivas pandruvada
@ 2022-01-06 13:18 ` Jiri Kosina
1 sibling, 0 replies; 3+ messages in thread
From: Jiri Kosina @ 2022-01-06 13:18 UTC (permalink / raw)
To: Ye Xiang; +Cc: jic23, srinivas.pandruvada, linux-input, linux-iio, linux-kernel
On Fri, 17 Dec 2021, Ye Xiang wrote:
> Specify that both TGL and ADL don't support DMA cache snooping.
>
> Signed-off-by: Ye Xiang <xiang.ye@intel.com>
> ---
> drivers/hid/intel-ish-hid/ipc/ipc.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hid/intel-ish-hid/ipc/ipc.c b/drivers/hid/intel-ish-hid/ipc/ipc.c
> index 45e0c7b1c9ec..8ccb246b0114 100644
> --- a/drivers/hid/intel-ish-hid/ipc/ipc.c
> +++ b/drivers/hid/intel-ish-hid/ipc/ipc.c
> @@ -909,7 +909,11 @@ static uint32_t ish_ipc_get_header(struct ishtp_device *dev, int length,
> */
> static bool _dma_no_cache_snooping(struct ishtp_device *dev)
> {
> - return dev->pdev->device == EHL_Ax_DEVICE_ID;
> + return (dev->pdev->device == EHL_Ax_DEVICE_ID ||
> + dev->pdev->device == TGL_LP_DEVICE_ID ||
> + dev->pdev->device == TGL_H_DEVICE_ID ||
> + dev->pdev->device == ADL_S_DEVICE_ID ||
> + dev->pdev->device == ADL_P_DEVICE_ID);
> }
Applied, thank you.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-01-06 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-17 7:45 [PATCH] HID: intel-ish-hid: ipc: Specify no cache snooping on TGL and ADL Ye Xiang
2021-12-17 12:33 ` srinivas pandruvada
2022-01-06 13:18 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).