* [PATCH] Input: ar1021 - do not force raising edge IRQ trigger
@ 2017-04-13 23:49 Dmitry Torokhov
2017-04-14 5:50 ` Martin Kepplinger
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Dmitry Torokhov @ 2017-04-13 23:49 UTC (permalink / raw)
To: linux-input
Cc: Martin Kepplinger, Guenter Roeck, Wolfram Sang, Jean Delvare,
Christian Gmeiner, linux-kernel
We should not be forcing edge triggered interrupt, but rather let platform
decide the kind of trigger it needs to use. Also, the driver is not quite
safe with regard to edge-triggered interrupts as it does not try to kick
the controller after requesting/enabling IRQ.
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
---
drivers/input/touchscreen/ar1021_i2c.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
index 6797e123925a..6c3c79b7ff51 100644
--- a/drivers/input/touchscreen/ar1021_i2c.c
+++ b/drivers/input/touchscreen/ar1021_i2c.c
@@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
error = devm_request_threaded_irq(&client->dev, client->irq,
NULL, ar1021_i2c_irq,
- IRQF_TRIGGER_RISING | IRQF_ONESHOT,
+ IRQF_ONESHOT,
"ar1021_i2c", ar1021);
if (error) {
dev_err(&client->dev,
--
2.12.2.762.g0e3151a226-goog
--
Dmitry
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger
2017-04-13 23:49 [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov
@ 2017-04-14 5:50 ` Martin Kepplinger
2017-04-14 7:33 ` Christian Gmeiner
2017-04-15 6:44 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Martin Kepplinger @ 2017-04-14 5:50 UTC (permalink / raw)
To: Dmitry Torokhov, linux-input
Cc: Guenter Roeck, Wolfram Sang, Jean Delvare, Christian Gmeiner,
linux-kernel
On 2017-04-14 01:49, Dmitry Torokhov wrote:
> We should not be forcing edge triggered interrupt, but rather let platform
> decide the kind of trigger it needs to use. Also, the driver is not quite
> safe with regard to edge-triggered interrupts as it does not try to kick
> the controller after requesting/enabling IRQ.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index 6797e123925a..6c3c79b7ff51 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>
> error = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, ar1021_i2c_irq,
> - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "ar1021_i2c", ar1021);
> if (error) {
> dev_err(&client->dev,
>
makes sense, if users have to expect that this default can change. it works.
Tested-by: Martin Kepplinger <martin.kepplinger@ginzinger.com>
martin
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger
2017-04-13 23:49 [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov
2017-04-14 5:50 ` Martin Kepplinger
@ 2017-04-14 7:33 ` Christian Gmeiner
2017-04-15 6:44 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Christian Gmeiner @ 2017-04-14 7:33 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, Martin Kepplinger, Guenter Roeck, Wolfram Sang,
Jean Delvare, LKML
2017-04-14 1:49 GMT+02:00 Dmitry Torokhov <dmitry.torokhov@gmail.com>:
> We should not be forcing edge triggered interrupt, but rather let platform
> decide the kind of trigger it needs to use. Also, the driver is not quite
> safe with regard to edge-triggered interrupts as it does not try to kick
> the controller after requesting/enabling IRQ.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-By: Christian Gmeiner <christian.gmeiner@gmail.com>
greets
--
Christian Gmeiner, MSc
https://www.youtube.com/user/AloryOFFICIAL
https://soundcloud.com/christian-gmeiner
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] Input: ar1021 - do not force raising edge IRQ trigger
2017-04-13 23:49 [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov
2017-04-14 5:50 ` Martin Kepplinger
2017-04-14 7:33 ` Christian Gmeiner
@ 2017-04-15 6:44 ` Jean Delvare
2 siblings, 0 replies; 4+ messages in thread
From: Jean Delvare @ 2017-04-15 6:44 UTC (permalink / raw)
To: Dmitry Torokhov
Cc: linux-input, Martin Kepplinger, Guenter Roeck, Wolfram Sang,
Christian Gmeiner, linux-kernel
On Thu, 13 Apr 2017 16:49:23 -0700, Dmitry Torokhov wrote:
> We should not be forcing edge triggered interrupt, but rather let platform
> decide the kind of trigger it needs to use. Also, the driver is not quite
> safe with regard to edge-triggered interrupts as it does not try to kick
> the controller after requesting/enabling IRQ.
>
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> ---
> drivers/input/touchscreen/ar1021_i2c.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/touchscreen/ar1021_i2c.c b/drivers/input/touchscreen/ar1021_i2c.c
> index 6797e123925a..6c3c79b7ff51 100644
> --- a/drivers/input/touchscreen/ar1021_i2c.c
> +++ b/drivers/input/touchscreen/ar1021_i2c.c
> @@ -109,7 +109,7 @@ static int ar1021_i2c_probe(struct i2c_client *client,
>
> error = devm_request_threaded_irq(&client->dev, client->irq,
> NULL, ar1021_i2c_irq,
> - IRQF_TRIGGER_RISING | IRQF_ONESHOT,
> + IRQF_ONESHOT,
> "ar1021_i2c", ar1021);
> if (error) {
> dev_err(&client->dev,
Acked-by: Jean Delvare <jdelvare@suse.de>
--
Jean Delvare
SUSE L3 Support
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-15 6:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-13 23:49 [PATCH] Input: ar1021 - do not force raising edge IRQ trigger Dmitry Torokhov
2017-04-14 5:50 ` Martin Kepplinger
2017-04-14 7:33 ` Christian Gmeiner
2017-04-15 6:44 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).