From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C4A8C433FE for ; Sat, 19 Nov 2022 13:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231598AbiKSNAu (ORCPT ); Sat, 19 Nov 2022 08:00:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233576AbiKSNAr (ORCPT ); Sat, 19 Nov 2022 08:00:47 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 145A974611 for ; Sat, 19 Nov 2022 04:59:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668862788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UM5/eK0x4588vJ74t5BQpzCz6Kkx7HScHipjUXodFbQ=; b=I/DLJcuTzCLjQzgztGARCHw3UFUYHK7J+AJSd4hKzJXQuX/Qevk8L7DrJqyZchqoeC7Mx5 wHLi3nfOlWeetTfNPTYEq9F9N3UjGK67zwPiTDDnITmQA/AyBOLVvZi6qQT9NmRxdULbk+ m7I1OhSp/fCrF1HIjBIRDAOTCYUv2lA= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-145-quvsZdZhOzOyRKutTBWOyA-1; Sat, 19 Nov 2022 07:59:38 -0500 X-MC-Unique: quvsZdZhOzOyRKutTBWOyA-1 Received: by mail-ed1-f71.google.com with SMTP id y20-20020a056402271400b004630f3a32c3so4132003edd.15 for ; Sat, 19 Nov 2022 04:59:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UM5/eK0x4588vJ74t5BQpzCz6Kkx7HScHipjUXodFbQ=; b=2lpgGh+xTsaXNNczVw/wChWNWbAr5qPrkJ7XZmGfL9C4atnkjSKw/IVjyDg0Yw7M/b sYHHWZqrLL1dyl35fTz5DlowtHH72DK5lunjU7JmNKLDLpGqyCSsBH9XqwUAnDiL2acc vbEfIhOlhFmnJ6PK7QU9XMbibXUhol3e8hDlvMrvgphKyqzCsSv46R0XTkfhebr8sdP6 yqSPYnUo+jMaEbfMNjJ9spi1Cig8N5BHWEzJXYdUoNq4pJXK6YMm1e27IVavAek9/yro 4RfXADBtlMpXKcDJISAiEKTyeR2J6nhIj9OJPHnFu7JM5jz1TJm+Aj/hhTg0ATxQzz17 5iqg== X-Gm-Message-State: ANoB5pkyaSVMimrfmuDrehDxXiCSUO7hD8axhZJA2jGbLTbp/MCzfZuP YUC9y/i2DrkMiJkBwTogG0RiSUbBzFgBdLa9tcqDTc+5rmblUrn/jqjZkNoR5+9vxaVNDsuHFvz dKTK51OHp8mVUWDYTeAcG7Bo= X-Received: by 2002:aa7:d5c9:0:b0:463:c64e:bc75 with SMTP id d9-20020aa7d5c9000000b00463c64ebc75mr9669429eds.205.1668862777662; Sat, 19 Nov 2022 04:59:37 -0800 (PST) X-Google-Smtp-Source: AA0mqf4006RzPisPmLsYq2FV4QIzE0awfpDSgLwy2GRRpncZj22swQXn47+gtoldOQ8YsQPVXmBsAg== X-Received: by 2002:aa7:d5c9:0:b0:463:c64e:bc75 with SMTP id d9-20020aa7d5c9000000b00463c64ebc75mr9669421eds.205.1668862777490; Sat, 19 Nov 2022 04:59:37 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id d12-20020a056402078c00b0045b3853c4b7sm2950296edy.51.2022.11.19.04.59.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 19 Nov 2022 04:59:36 -0800 (PST) Message-ID: <4e3deedc-40f1-0bf9-798b-88185bd89be8@redhat.com> Date: Sat, 19 Nov 2022 13:59:36 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [PATCH 257/606] Input: silead - Convert to i2c's .probe_new() Content-Language: en-US, nl To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Angel Iglesias , Lee Jones , Grant Likely , Wolfram Sang , Dmitry Torokhov Cc: linux-i2c@vger.kernel.org, kernel@pengutronix.de, =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221118224540.619276-1-uwe@kleine-koenig.org> <20221118224540.619276-258-uwe@kleine-koenig.org> From: Hans de Goede In-Reply-To: <20221118224540.619276-258-uwe@kleine-koenig.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 11/18/22 23:39, Uwe Kleine-König wrote: > From: Uwe Kleine-König > > .probe_new() doesn't get the i2c_device_id * parameter, so determine > that explicitly in the probe function. > > Signed-off-by: Uwe Kleine-König Thanks, patch looks good to me: Reviewed-by: Hans de Goede Regards, Hans > --- > drivers/input/touchscreen/silead.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c > index 3eef8c01090f..8a7351c4414c 100644 > --- a/drivers/input/touchscreen/silead.c > +++ b/drivers/input/touchscreen/silead.c > @@ -652,9 +652,9 @@ static void silead_disable_regulator(void *arg) > regulator_bulk_disable(ARRAY_SIZE(data->regulators), data->regulators); > } > > -static int silead_ts_probe(struct i2c_client *client, > - const struct i2c_device_id *id) > +static int silead_ts_probe(struct i2c_client *client) > { > + const struct i2c_device_id *id = i2c_client_get_device_id(client); > struct silead_ts_data *data; > struct device *dev = &client->dev; > int error; > @@ -826,7 +826,7 @@ MODULE_DEVICE_TABLE(of, silead_ts_of_match); > #endif > > static struct i2c_driver silead_ts_driver = { > - .probe = silead_ts_probe, > + .probe_new = silead_ts_probe, > .id_table = silead_ts_id, > .driver = { > .name = SILEAD_TS_NAME,