From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 081DF218E81; Wed, 5 Feb 2025 10:34:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738751654; cv=none; b=WOIHqpB2onb1XSk4vMW27bTGJUXfKeoArOnT4Rha0Zx2P6BdRp43QkDTOyB0NlSBe3911WhpY9ZMhkVkqnM0sEj+abjNPm1GzHS8JqD4Eyihj02f0/C9QgP87lZpPhAPyvEQoJ7kSthVLlh4CbqnMzzYDHSk08sHuOJOq43kPA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738751654; c=relaxed/simple; bh=+X2YS141cpNkGzdhxy3GDXh74+VGoQVLUMPaaHTcFww=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gvxRj9ZU26T4GJQfPYHAV30Thojl6jpM/K62ELG2drHclntMSrLC7yvsD4+WqqAmwvKz7/9jGfe9RfFgtB0Ir7Rda/DhjwCwZjA3bFzGs/UFEUkJOyO+HfVPlzK7yVbMkrOcXYi2KYOKJ2ogDIDl3eyjQH/5wAyzXtWJIsMZ8xI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=n/PYf/Mi; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="n/PYf/Mi" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B0D28C4CED1; Wed, 5 Feb 2025 10:34:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1738751653; bh=+X2YS141cpNkGzdhxy3GDXh74+VGoQVLUMPaaHTcFww=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=n/PYf/MihMEldNv1ZIRPR0CDS2YrxruLlvBWS6t7ZrWx+e5LFjNWkYIR9/Zu2uMYE cX7xBravvlIxHiGPg7d8HVOh9kO3exQKgwdIwFUr+Cau/OENAXHAMtFxzDTdxBlMKZ F4QHK5HQgg55oF1IF0uUgFllwhfYNUJEXtmrUDluR03Fdygk9Hqou+kv85SVCWLtHZ QWWdlEoP72xhfexp/p3jFqAMPqR/Na2DhGxp2OM3qZOuw+INtph8Nh35jEJhmFW8o/ mVotOYenGmLq4HS1NdPsnbxfS1xw+WBfqY+HKBlY8B+MwKTH3WyVmfFiLIJKDH0RO1 W89+bwj+YvqSQ== Message-ID: <4e5f0194-22bc-4e17-85f4-6dbc145a936b@kernel.org> Date: Wed, 5 Feb 2025 11:34:04 +0100 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RESEND 5/7] mfd: cs40l26: Add support for CS40L26 core driver To: Fred Treven , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simon Trimmer , Charles Keepax , Richard Fitzgerald , Dmitry Torokhov , James Ogletree , Ben Bright , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , David Rhodes , Jeff LaBundy , Heiko Stuebner , Karel Balej , Igor Prusov , Jack Yu , Weidong Wang , Binbin Zhou , Prasad Kumpatla , Paul Handrigan , Masahiro Yamada , Nuno Sa Cc: alsa-devel@alsa-project.org, patches@opensource.cirrus.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, linux-sound@vger.kernel.org References: <20250204231835.2000457-1-ftreven@opensource.cirrus.com> <20250204231835.2000457-6-ftreven@opensource.cirrus.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJgPO8PBQkUX63hAAoJEBuTQ307 QWKbBn8P+QFxwl7pDsAKR1InemMAmuykCHl+XgC0LDqrsWhAH5TYeTVXGSyDsuZjHvj+FRP+ gZaEIYSw2Yf0e91U9HXo3RYhEwSmxUQ4Fjhc9qAwGKVPQf6YuQ5yy6pzI8brcKmHHOGrB3tP /MODPt81M1zpograAC2WTDzkICfHKj8LpXp45PylD99J9q0Y+gb04CG5/wXs+1hJy/dz0tYy iua4nCuSRbxnSHKBS5vvjosWWjWQXsRKd+zzXp6kfRHHpzJkhRwF6ArXi4XnQ+REnoTfM5Fk VmVmSQ3yFKKePEzoIriT1b2sXO0g5QXOAvFqB65LZjXG9jGJoVG6ZJrUV1MVK8vamKoVbUEe 0NlLl/tX96HLowHHoKhxEsbFzGzKiFLh7hyboTpy2whdonkDxpnv/H8wE9M3VW/fPgnL2nPe xaBLqyHxy9hA9JrZvxg3IQ61x7rtBWBUQPmEaK0azW+l3ysiNpBhISkZrsW3ZUdknWu87nh6 eTB7mR7xBcVxnomxWwJI4B0wuMwCPdgbV6YDUKCuSgRMUEiVry10xd9KLypR9Vfyn1AhROrq AubRPVeJBf9zR5UW1trJNfwVt3XmbHX50HCcHdEdCKiT9O+FiEcahIaWh9lihvO0ci0TtVGZ MCEtaCE80Q3Ma9RdHYB3uVF930jwquplFLNF+IBCn5JRzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmA872oFCRRflLYACgkQG5NDfTtBYpvScw/9GrqBrVLuJoJ52qBBKUBDo4E+5fU1bjt0 Gv0nh/hNJuecuRY6aemU6HOPNc2t8QHMSvwbSF+Vp9ZkOvrM36yUOufctoqON+wXrliEY0J4 ksR89ZILRRAold9Mh0YDqEJc1HmuxYLJ7lnbLYH1oui8bLbMBM8S2Uo9RKqV2GROLi44enVt vdrDvo+CxKj2K+d4cleCNiz5qbTxPUW/cgkwG0lJc4I4sso7l4XMDKn95c7JtNsuzqKvhEVS oic5by3fbUnuI0cemeizF4QdtX2uQxrP7RwHFBd+YUia7zCcz0//rv6FZmAxWZGy5arNl6Vm lQqNo7/Poh8WWfRS+xegBxc6hBXahpyUKphAKYkah+m+I0QToCfnGKnPqyYIMDEHCS/RfqA5 t8F+O56+oyLBAeWX7XcmyM6TGeVfb+OZVMJnZzK0s2VYAuI0Rl87FBFYgULdgqKV7R7WHzwD uZwJCLykjad45hsWcOGk3OcaAGQS6NDlfhM6O9aYNwGL6tGt/6BkRikNOs7VDEa4/HlbaSJo 7FgndGw1kWmkeL6oQh7wBvYll2buKod4qYntmNKEicoHGU+x91Gcan8mCoqhJkbqrL7+nXG2 5Q/GS5M9RFWS+nYyJh+c3OcfKqVcZQNANItt7+ULzdNJuhvTRRdC3g9hmCEuNSr+CLMdnRBY fv0= In-Reply-To: <20250204231835.2000457-6-ftreven@opensource.cirrus.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 05/02/2025 00:18, Fred Treven wrote: > Introduce support for Cirrus Logic Device CS40L26: > A boosted haptic driver with integrated DSP and > waveform memory with advanced closed loop algorithms > and LRA protection. > Please wrap commit message according to Linux coding style / submission process (neither too early nor over the limit): https://elixir.bootlin.com/linux/v6.4-rc1/source/Documentation/process/submitting-patches.rst#L597 > + > +#include > +#include > +#include > +#include > +#include > + > +static const struct mfd_cell cs40l26_devs[] = { > + { .name = "cs40l26-codec", }, > + { .name = "cs40l26-vibra", }, > +}; > + > +const struct regmap_config cs40l26_regmap = { > + .reg_bits = 32, > + .val_bits = 32, > + .reg_stride = 4, > + .reg_format_endian = REGMAP_ENDIAN_BIG, > + .val_format_endian = REGMAP_ENDIAN_BIG, > + .max_register = CS40L26_LASTREG, > + .cache_type = REGCACHE_NONE, > +}; > +EXPORT_SYMBOL_GPL(cs40l26_regmap); > + > +static const char *const cs40l26_supplies[] = { > + "va", "vp", > +}; > + > +inline void cs40l26_pm_exit(struct device *dev) Exported function and inlined? This feels odd. Anyway, don't use any inline keywords in C units. > +{ > + pm_runtime_mark_last_busy(dev); > + pm_runtime_put_autosuspend(dev); > +} > +EXPORT_SYMBOL_GPL(cs40l26_pm_exit); > + > +static int cs40l26_fw_write_raw(struct cs_dsp *dsp, const char *const name, > + const unsigned int algo_id, const u32 offset_words, > + const size_t len_words, u32 *buf) > +{ > + struct cs_dsp_coeff_ctl *ctl; > + __be32 *val; > + int i, ret; > + > + ctl = cs_dsp_get_ctl(dsp, name, WMFW_ADSP2_XM, algo_id); > + if (!ctl) { > + dev_err(dsp->dev, "Failed to find FW control %s\n", name); > + return -EINVAL; > + } > + > + val = kzalloc(len_words * sizeof(u32), GFP_KERNEL); Looks like an array, so kcalloc > + if (!val) > + return -ENOMEM; > + > + for (i = 0; i < len_words; i++) > + val[i] = cpu_to_be32(buf[i]); > + > + ret = cs_dsp_coeff_write_ctrl(ctl, offset_words, val, len_words * sizeof(u32)); > + if (ret < 0) > + dev_err(dsp->dev, "Failed to write FW control %s\n", name); > + > + kfree(val); > + > + return (ret < 0) ? ret : 0; > +} > + > +inline int cs40l26_fw_write(struct cs_dsp *dsp, const char *const name, const unsigned int algo_id, > + u32 val) > +{ > + return cs40l26_fw_write_raw(dsp, name, algo_id, 0, 1, &val); > +} > +EXPORT_SYMBOL_GPL(cs40l26_fw_write); > + > +static int cs40l26_fw_read_raw(struct cs_dsp *dsp, const char *const name, > + const unsigned int algo_id, const unsigned int offset_words, > + const size_t len_words, u32 *buf) > +{ > + struct cs_dsp_coeff_ctl *ctl; > + int i, ret; > + > + ctl = cs_dsp_get_ctl(dsp, name, WMFW_ADSP2_XM, algo_id); > + if (!ctl) { > + dev_err(dsp->dev, "Failed to find FW control %s\n", name); > + return -EINVAL; > + } > + > + ret = cs_dsp_coeff_read_ctrl(ctl, offset_words, buf, len_words * sizeof(u32)); > + if (ret) { > + dev_err(dsp->dev, "Failed to read FW control %s\n", name); > + return ret; > + } > + > + for (i = 0; i < len_words; i++) > + buf[i] = be32_to_cpu(buf[i]); > + > + return 0; > +} > + > +inline int cs40l26_fw_read(struct cs_dsp *dsp, const char *const name, const unsigned int algo_id, All your exported functions should have kerneldoc. > + u32 *buf) > +{ > + return cs40l26_fw_read_raw(dsp, name, algo_id, 0, 1, buf); > +} > +EXPORT_SYMBOL_GPL(cs40l26_fw_read); > + > +static struct cs40l26_irq *cs40l26_get_irq(struct cs40l26 *cs40l26, const int num, const int bit); > + > +static int cs40l26_gpio1_rise_irq(void *data) > +{ > + struct cs40l26 *cs40l26 = data; > + > + if (cs40l26->wksrc_sts & CS40L26_WKSRC_STS_EN) > + dev_dbg(cs40l26->dev, "GPIO1 Rising Edge Detected\n"); > + > + cs40l26->wksrc_sts |= CS40L26_WKSRC_STS_EN; > + > + return 0; > +} ... > +err: > + dev_err(cs40l26->dev, "Invalid revision 0x%02X for device 0x%06X\n", cs40l26->revid, > + cs40l26->devid); > + return -EINVAL; > +} > + > +int cs40l26_set_pll_loop(struct cs40l26 *cs40l26, const u32 pll_loop) > +{ > + int i; > + > + /* Retry in case DSP is hibernating */ > + for (i = 0; i < CS40L26_PLL_NUM_SET_ATTEMPTS; i++) { > + if (!regmap_update_bits(cs40l26->regmap, CS40L26_REFCLK_INPUT, > + CS40L26_PLL_REFCLK_LOOP_MASK, > + pll_loop << CS40L26_PLL_REFCLK_LOOP_SHIFT)) > + break; > + } > + > + if (i == CS40L26_PLL_NUM_SET_ATTEMPTS) { > + dev_err(cs40l26->dev, "Failed to configure PLL\n"); > + return -ETIMEDOUT; > + } > + > + return 0; > +} > +EXPORT_SYMBOL_GPL(cs40l26_set_pll_loop); > + This looks way past simple MFD driver. Not only this - entire file. You configure there quite a lot and for example setting PLLs is not job for MFD. This should be placed in appropriate subsystem. > + > +static const struct cs_dsp_client_ops cs40l26_cs_dsp_client_ops = { > + .pre_run = cs40l26_cs_dsp_pre_run, > + .post_run = cs40l26_cs_dsp_post_run, > +}; > + > +static void cs40l26_cs_dsp_remove(void *data) > +{ > + cs_dsp_remove((struct cs_dsp *)data); > +} > + > +static struct cs_dsp_coeff_desc cs40l26_coeffs[] = { This cannto be const? > + { .coeff_firmware = NULL, .coeff_filename = "cs40l26.bin" }, > + { .coeff_firmware = NULL, .coeff_filename = "cs40l26-svc.bin" }, > + { .coeff_firmware = NULL, .coeff_filename = "cs40l26-dvl.bin" }, > +}; > + > +static int cs40l26_cs_dsp_init(struct cs40l26 *cs40l26) > +{ > + struct cs_dsp *dsp = &cs40l26->dsp; > + int ret; > + > + dsp->num = 1; > + dsp->type = WMFW_HALO; > + dsp->dev = cs40l26->dev; > + dsp->regmap = cs40l26->regmap; > + dsp->base = CS40L26_DSP_CTRL_BASE; > + dsp->base_sysinfo = CS40L26_DSP1_SYS_INFO_ID; > + dsp->mem = cs40l26_dsp_regions; > + dsp->num_mems = ARRAY_SIZE(cs40l26_dsp_regions); > + dsp->client_ops = &cs40l26_cs_dsp_client_ops; > + > + ret = cs_dsp_halo_init(dsp); > + if (ret) { > + dev_err(cs40l26->dev, "Failed to initialize HALO core\n"); > + return ret; > + } > + ... > + > +static int __maybe_unused cs40l26_suspend(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + guard(mutex)(&cs40l26->lock); > + > + dev_dbg(dev, "%s: Enabling hibernation\n", __func__); Drop. No need to re-implement tracing. > + > + cs40l26->wksrc_sts = 0x00; > + > + /* Don't poll DSP since reading for ACK will wake the device again */ > + return regmap_write(cs40l26->regmap, CS40L26_DSP_QUEUE, CS40L26_DSP_CMD_ALLOW_HIBER); > +} > + > +static int __maybe_unused cs40l26_sys_suspend(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + dev_dbg(dev, "System suspend, disabling IRQ\n"); Drop. > + > + disable_irq(cs40l26->irq); > + > + return 0; > +} > + > +static int __maybe_unused cs40l26_sys_suspend_noirq(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + dev_dbg(dev, "Late system suspend, re-enabling IRQ\n"); Drop. > + > + enable_irq(cs40l26->irq); > + > + return 0; > +} > + > +static int __maybe_unused cs40l26_resume(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + dev_dbg(dev, "%s: Disabling hibernation\n", __func__); Drop. > + > + guard(mutex)(&cs40l26->dsp.pwr_lock); > + > + return cs40l26_prevent_hiber(cs40l26); > +} > + > +static int __maybe_unused cs40l26_sys_resume(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + dev_dbg(dev, "System resume, re-enabling IRQ\n"); Drop. > + > + enable_irq(cs40l26->irq); > + > + return 0; > +} > + > +static int __maybe_unused cs40l26_sys_resume_noirq(struct device *dev) > +{ > + struct cs40l26 *cs40l26 = dev_get_drvdata(dev); > + > + dev_dbg(dev, "Early system resume, disabling IRQ\n"); > + Drop. ... > + > +static int cs40l26_spi_probe(struct spi_device *spi) > +{ > + struct cs40l26 *cs40l26; > + > + cs40l26 = devm_kzalloc(&spi->dev, sizeof(struct cs40l26), GFP_KERNEL); sizeof(*) > + if (!cs40l26) > + return -ENOMEM; > + > + spi_set_drvdata(spi, cs40l26); > + > + cs40l26->dev = &spi->dev; > + cs40l26->irq = spi->irq; > + cs40l26->bus = &spi_bus_type; > + > + cs40l26->regmap = devm_regmap_init_spi(spi, &cs40l26_regmap); > + if (IS_ERR(cs40l26->regmap)) > + return dev_err_probe(cs40l26->dev, PTR_ERR(cs40l26->regmap), > + "Failed to allocate register map\n"); > + > + return cs40l26_probe(cs40l26); > +} > + > +static const struct spi_device_id cs40l26_id_spi[] = { > + { "cs40l26a", 0 }, > + { "cs40l27b", 1 }, What are these 0 and 1? > + {} > +}; > +MODULE_DEVICE_TABLE(spi, cs40l26_id_spi); > + > +static const struct of_device_id cs40l26_of_match[] = { > + { .compatible = "cirrus,cs40l26a" }, > + { .compatible = "cirrus,cs40l27b" }, So devices are compatible? Or rather this is unsynced with other ID table. Best regards, Krzysztof