From: "Arnd Bergmann" <arnd@arndb.de>
To: "Raag Jadav" <raag.jadav@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
"Linus Walleij" <linus.walleij@linaro.org>,
"Mika Westerberg" <mika.westerberg@linux.intel.com>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>,
"Dmitry Torokhov" <dmitry.torokhov@gmail.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Przemek Kitszel" <przemyslaw.kitszel@intel.com>
Cc: "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-iio@vger.kernel.org
Subject: Re: [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h
Date: Wed, 12 Feb 2025 07:41:47 +0100 [thread overview]
Message-ID: <4ea5bd29-3d42-440b-bbea-203479116b48@app.fastmail.com> (raw)
In-Reply-To: <20250212062513.2254767-3-raag.jadav@intel.com>
On Wed, Feb 12, 2025, at 07:25, Raag Jadav wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>
> device.h is a huge header which is hard to follow and easy to miss
> something. Improve that by splitting devres APIs to device/devres.h.
>
> In particular this helps to speedup the build of the code that includes
> device.h solely for a devres APIs.
>
> While at it, cast the error pointers to __iomem using IOMEM_ERR_PTR()
> and fix sparse warnings.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Signed-off-by: Raag Jadav <raag.jadav@intel.com>
> ---
> include/linux/device.h | 119 +-------------------------------
> include/linux/device/devres.h | 124 ++++++++++++++++++++++++++++++++++
Acked-by: Arnd Bergmann <arnd@arndb.de>
Splitting this out makes a lot of sense conceptually, though
I don't think it will actually help with build speed: In order
to see real benefits, we'd need to remove the linux/device.h
inclusion from other headers that are frequently included,
but those don't really rely on the devres interfaces.
Arnd
next prev parent reply other threads:[~2025-02-12 6:42 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-12 6:25 [PATCH v5 00/12] Split devres APIs to device/devres.h and introduce devm_kmemdup_array() Raag Jadav
2025-02-12 6:25 ` [PATCH v5 01/12] err.h: move IOMEM_ERR_PTR() to err.h Raag Jadav
2025-02-12 6:32 ` Arnd Bergmann
2025-02-12 6:25 ` [PATCH v5 02/12] driver core: Split devres APIs to device/devres.h Raag Jadav
2025-02-12 6:41 ` Arnd Bergmann [this message]
2025-02-12 11:00 ` Andy Shevchenko
2025-02-20 11:59 ` Greg KH
2025-02-20 12:18 ` Andy Shevchenko
2025-02-12 6:25 ` [PATCH v5 03/12] iio: imu: st_lsm9ds0: Replace device.h with what is needed Raag Jadav
2025-02-12 6:25 ` [PATCH v5 04/12] devres: Introduce devm_kmemdup_array() Raag Jadav
2025-02-12 6:25 ` [PATCH v5 05/12] pinctrl: intel: copy communities using devm_kmemdup_array() Raag Jadav
2025-02-12 6:25 ` [PATCH v5 06/12] pinctrl: baytrail: " Raag Jadav
2025-02-12 6:25 ` [PATCH v5 07/12] pinctrl: cherryview: use devm_kmemdup_array() Raag Jadav
2025-02-12 6:25 ` [PATCH v5 08/12] pinctrl: tangier: " Raag Jadav
2025-02-12 6:25 ` [PATCH v5 09/12] pinctrl: pxa2xx: " Raag Jadav
2025-02-12 6:25 ` [PATCH v5 10/12] iio: adc: xilinx-xadc-core: " Raag Jadav
2025-02-16 16:59 ` Jonathan Cameron
2025-02-12 6:25 ` [PATCH v5 11/12] input: sparse-keymap: " Raag Jadav
2025-02-12 6:25 ` [PATCH v5 12/12] input: ipaq-micro-keys: " Raag Jadav
2025-02-12 11:05 ` [PATCH v5 00/12] Split devres APIs to device/devres.h and introduce devm_kmemdup_array() Andy Shevchenko
2025-02-12 16:22 ` Raag Jadav
2025-02-12 17:21 ` Andy Shevchenko
2025-02-20 12:19 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ea5bd29-3d42-440b-bbea-203479116b48@app.fastmail.com \
--to=arnd@arndb.de \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=przemyslaw.kitszel@intel.com \
--cc=raag.jadav@intel.com \
--cc=rafael@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).