From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89E6AC4321E for ; Tue, 15 Nov 2022 20:37:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230136AbiKOUhe (ORCPT ); Tue, 15 Nov 2022 15:37:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45274 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230449AbiKOUhD (ORCPT ); Tue, 15 Nov 2022 15:37:03 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2A07F2982E for ; Tue, 15 Nov 2022 12:33:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1668544433; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VVhrvYGZTZ9CuRZyU7m2CWqpbNzAXMXlYEZ9jNaCYQQ=; b=gtrDOw5obo6hRELqOadyYoh9zPAies91O2xsxjetyffGPSeLiMhqLDo4B8nWFYt2gDZM5S 9yW5uDJU2TxKXoDmcLgHpWuw9gC07lGIVWwMgzEuUeDvUDkOSdRF2fjJg+qL+PiBIBzlqX jJP6sUU1X3twbgQx93KXMgBRbibboNk= Received: from mail-ej1-f72.google.com (mail-ej1-f72.google.com [209.85.218.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-541-7V-1i-buPbKMf0bBiYJhHA-1; Tue, 15 Nov 2022 15:33:52 -0500 X-MC-Unique: 7V-1i-buPbKMf0bBiYJhHA-1 Received: by mail-ej1-f72.google.com with SMTP id xh12-20020a170906da8c00b007413144e87fso8050102ejb.14 for ; Tue, 15 Nov 2022 12:33:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=VVhrvYGZTZ9CuRZyU7m2CWqpbNzAXMXlYEZ9jNaCYQQ=; b=KBVk+qWZ+wPE6TF1dYE8pddqub9XLa01LaAqgEj0DtPnuXkBLk6UogC/VuBGjM216U jbCSeFfeBELnt2pB9G8/wXHfz2m1RMr5MdeP5rXBSIY0g/Ja+eO5cU/dBPOt2Daz0b1U TOxxcaSieizavsF/uy998Zonz5ebNAEbN6WR0EAuXreQ1hJuF4ujDf9u0z5QXlAsaJpb 6odo5dzIPbZCT6UqO13dpE4rnNurVGBl8v6Ri07HdCdm4EmUyG/1Hdy+ebusjUO+j19Q 5sKnPdz/4QfH6yaRIHEzwwS9HI1Owk53viVLSZIudRAj03m69M8AxVDkzUe3YTA7kLPJ 2zgQ== X-Gm-Message-State: ANoB5plp/Seimypzq5QkvUX5F3e1kUDKzoT5/L/jIMXGHRNaUXit7v4B nuYPveXWVbP+11gNeh6X5nSOqk0I0tm+L7pWFViTdZwWcwIF8hvzWu2lcM2dSipnbTm66F/RxDl 8PR6ma9iFaseHxixw3p3xIUc= X-Received: by 2002:a17:907:80c5:b0:7ad:f43a:cb07 with SMTP id io5-20020a17090780c500b007adf43acb07mr14926770ejc.562.1668544430558; Tue, 15 Nov 2022 12:33:50 -0800 (PST) X-Google-Smtp-Source: AA0mqf4S4colGM0tju7JziGafsLeOa86LQ77NWGN8k/GwvIPubzSP+mStQZmQY2YAMgEPilGOieF/A== X-Received: by 2002:a17:907:80c5:b0:7ad:f43a:cb07 with SMTP id io5-20020a17090780c500b007adf43acb07mr14926761ejc.562.1668544430383; Tue, 15 Nov 2022 12:33:50 -0800 (PST) Received: from ?IPV6:2001:1c00:c1e:bf00:d69d:5353:dba5:ee81? (2001-1c00-0c1e-bf00-d69d-5353-dba5-ee81.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:d69d:5353:dba5:ee81]) by smtp.gmail.com with ESMTPSA id z4-20020a1709063ac400b007acd04fcedcsm5968943ejd.46.2022.11.15.12.33.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Nov 2022 12:33:49 -0800 (PST) Message-ID: <4f6e561b-12d7-0163-5f26-05d47a72d6cb@redhat.com> Date: Tue, 15 Nov 2022 21:33:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v2 2/7] HID: add mapping for camera access keys Content-Language: en-US, nl To: =?UTF-8?Q?Eray_Or=c3=a7unus?= , platform-driver-x86@vger.kernel.org, dmitry.torokhov@gmail.com Cc: linux-kernel@vger.kernel.org, linux-input@vger.kernel.org, ike.pan@canonical.com, jikos@kernel.org, benjamin.tissoires@redhat.com, mgross@linux.intel.com, pobrn@protonmail.com References: <20221029120311.11152-1-erayorcunus@gmail.com> <20221029120311.11152-3-erayorcunus@gmail.com> From: Hans de Goede In-Reply-To: <20221029120311.11152-3-erayorcunus@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi Dmitry, On 10/29/22 14:03, Eray Orçunus wrote: > HUTRR72 added 3 new usage codes for keys that are supposed to enable, > disable and toggle camera access. These are useful, considering many > laptops today have key(s) for toggling access to camera. > > This patch adds new key definitions for KEY_CAMERA_ACCESS_ENABLE, > KEY_CAMERA_ACCESS_DISABLE and KEY_CAMERA_ACCESS_TOGGLE. Additionally > hid-debug is adjusted to recognize this new usage codes as well. > > Signed-off-by: Eray Orçunus > Acked-by: Dmitry Torokhov I have rejected the drivers/platform/x86 patch which depends on this, because it changes current behavior, potentially breaking userspace. Since this means I won't be taking any patches depending on this I believe it is best if this is merged through the input tree. Note this also has a: Acked-by: Jiri Kosina tag given in this email thread. Regards, Hans > --- > drivers/hid/hid-debug.c | 3 +++ > drivers/hid/hid-input.c | 3 +++ > include/uapi/linux/input-event-codes.h | 3 +++ > 3 files changed, 9 insertions(+) > > diff --git a/drivers/hid/hid-debug.c b/drivers/hid/hid-debug.c > index f48d3534e020..991f880fdbd4 100644 > --- a/drivers/hid/hid-debug.c > +++ b/drivers/hid/hid-debug.c > @@ -936,6 +936,9 @@ static const char *keys[KEY_MAX + 1] = { > [KEY_ASSISTANT] = "Assistant", > [KEY_KBD_LAYOUT_NEXT] = "KbdLayoutNext", > [KEY_EMOJI_PICKER] = "EmojiPicker", > + [KEY_CAMERA_ACCESS_ENABLE] = "CameraAccessEnable", > + [KEY_CAMERA_ACCESS_DISABLE] = "CameraAccessDisable", > + [KEY_CAMERA_ACCESS_TOGGLE] = "CameraAccessToggle", > [KEY_DICTATE] = "Dictate", > [KEY_BRIGHTNESS_MIN] = "BrightnessMin", > [KEY_BRIGHTNESS_MAX] = "BrightnessMax", > diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c > index f197aed6444a..f8e6513e77b8 100644 > --- a/drivers/hid/hid-input.c > +++ b/drivers/hid/hid-input.c > @@ -995,6 +995,9 @@ static void hidinput_configure_usage(struct hid_input *hidinput, struct hid_fiel > case 0x0cd: map_key_clear(KEY_PLAYPAUSE); break; > case 0x0cf: map_key_clear(KEY_VOICECOMMAND); break; > > + case 0x0d5: map_key_clear(KEY_CAMERA_ACCESS_ENABLE); break; > + case 0x0d6: map_key_clear(KEY_CAMERA_ACCESS_DISABLE); break; > + case 0x0d7: map_key_clear(KEY_CAMERA_ACCESS_TOGGLE); break; > case 0x0d8: map_key_clear(KEY_DICTATE); break; > case 0x0d9: map_key_clear(KEY_EMOJI_PICKER); break; > > diff --git a/include/uapi/linux/input-event-codes.h b/include/uapi/linux/input-event-codes.h > index 7989d9483ea7..ef392d0f943f 100644 > --- a/include/uapi/linux/input-event-codes.h > +++ b/include/uapi/linux/input-event-codes.h > @@ -614,6 +614,9 @@ > #define KEY_KBD_LAYOUT_NEXT 0x248 /* AC Next Keyboard Layout Select */ > #define KEY_EMOJI_PICKER 0x249 /* Show/hide emoji picker (HUTRR101) */ > #define KEY_DICTATE 0x24a /* Start or Stop Voice Dictation Session (HUTRR99) */ > +#define KEY_CAMERA_ACCESS_ENABLE 0x24b /* Enables programmatic access to camera devices. (HUTRR72) */ > +#define KEY_CAMERA_ACCESS_DISABLE 0x24c /* Disables programmatic access to camera devices. (HUTRR72) */ > +#define KEY_CAMERA_ACCESS_TOGGLE 0x24d /* Toggles the current state of the camera access control. (HUTRR72) */ > > #define KEY_BRIGHTNESS_MIN 0x250 /* Set Brightness to Minimum */ > #define KEY_BRIGHTNESS_MAX 0x251 /* Set Brightness to Maximum */