From mboxrd@z Thu Jan 1 00:00:00 1970 From: Qiao Zhou Subject: Re: [PATCH V10] add 88pm80x onkey driver Date: Tue, 24 Jul 2012 14:44:46 +0800 Message-ID: <500E445E.3000307@marvell.com> References: <1342509459-16976-1-git-send-email-zhouqiao@marvell.com> <500591FB.3020600@marvell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from na3sys009aog107.obsmtp.com ([74.125.149.197]:37263 "EHLO na3sys009aog107.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754530Ab2GXGov (ORCPT ); Tue, 24 Jul 2012 02:44:51 -0400 In-Reply-To: <500591FB.3020600@marvell.com> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Samuel Ortiz , Dmitry Torokhov , "linux-input@vger.kernel.org" On 07/18/2012 12:25 AM, Qiao Zhou wrote: > On 07/17/2012 03:17 PM, Qiao Zhou wrote: >> change log [v10->v9]: >> 1, change pr_err to dev_err. >> 2, add device_init_wakeup(,0) when device removes. >> 3, add ack by Dmitry. >> >> change log [v9->v8]: >> 1, remove devm_xxx api. >> 2, fix the potential oops issue. >> 3, use __set_bit to set key_bit. >> >> change log [v8->v7]: >> 1, remove file name in comments. >> 2, add error handling to regmap_read. >> 3, remove unnecessary onkey suspend/resume wrapper api. >> 4, remove the pm80x_chip cast by directly define the struct type. >> 5, fix the double free input device issue. >> >> change log [v7->v6]: >> 1, add the ack by Arnd for the first two patches. >> 2, add NULL terminater for id_table in 88pm800.c & 88pm805.c. >> >> change log [v6->v5]: >> export_symbol_gpl for pm80x_regmap_config to fix build issue for module. >> >> change log [v5->v4]: >> 1, change the file name, from 88pm800-core.c, 88pm805-core.c, >> 88pm80x-i2c.c >> to 88pm800.c, 88pm805.c, 88pm80x.c, and modified Makefile accordingly. >> 2, replace the spinlock used to protect wakeup flag, with using set_bit/ >> clear_bit, which is suitable adn enough in SMP env. >> 3, add the version number in each patch. >> >> change log [v4->v3]: >> 1, provide unified suspend/resume api for all sub-devices, and add >> protection for 800 & 805 wakeup flag in SMP case. >> 2, clean register definition in 88pm80x.h, and thanks Arnd's help. >> 3, some minor changes in mfd Kconfig/Makefile. >> >> change log [v3->v2]: >> 1, dynamically get the irq_base, for both regmap_add_irq_chip and >> mfd_add_devices. add pm80x_request_irq & pm80x_free_irq for sub-driver >> facility, and modify related irq thread operation. remove irq_base member >> from 80x_chip & platform data. >> 2, split 88pm80x.o into 3 separate modules. >> 3, remove the 88pm80x r/w API, and directly use open-coded regmap api. >> 4, minor change: move pm80x_id_table from 80x-i2c.c to 800/805-core.c, >> exported pm80x_init, pm80x_deinit, and pm80x_bulk_read, add callback in >> pdata. >> >> change log [v2->v1]: >> 1, split 88pm80x-core.c into 88pm800-core.c and 88pm805.c, per Arnd's >> suggestion. after the re-arch, 88pm80x-i2c handles the 800 & 805 common >> parts, while 800-core.c & 805-core.c handle the specific parts in each >> chip. >> 2, add details about the workaround adding a i2c companion between 800 & >> 805, and make a separate patch for it, per Arnd's suggestion. >> 3, remove callback in pdata. but still keep the pdata currently. >> 4, only keep necessary register in 88pm80x.h, including registers for >> regulator/rtc/onkey/power/codec etc, and remove other registers from >> global >> visibility. >> 5, exported r/w API which requires regmap handle. as currently the pm800 >> chip has 3 i2c device, only passing a pm80x_chip info can't ensure r/w >> the >> register in correct i2c device. >> >> change log [v1]: >> 1, pm800 and pm805 are decoupled and probed separately; >> 2, re-used the most of API for pm800 and pm805 per Arnd's comments; >> 3, use regmap_irq, instead of previous 88pm80x_irq_data per Mark's >> comments. >> use regmap_add_irq_chip, and remove previous 88pm80x irq handling. >> 4, remove callback function in rtc pdata per Arnd's comments. >> 5, updated some coding style issue. >> >> Qiao Zhou (1): >> input: add onkey support to 88PM80X PMIC >> >> drivers/input/misc/88pm80x_onkey.c | 168 >> ++++++++++++++++++++++++++++++++++++ >> drivers/input/misc/Kconfig | 10 ++ >> drivers/input/misc/Makefile | 1 + >> 3 files changed, 179 insertions(+), 0 deletions(-) >> create mode 100644 drivers/input/misc/88pm80x_onkey.c >> > Hi Samuel, > > would you please help check and apply this patch as it's ACKed by Dmitry? > Hi Samuel, do you have any suggestion about this patch? -- Best Regards Qiao