From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Mack Subject: Re: [PATCH v2 1/2] input: rotary-encoder: switch to devm_* allocation of GPIOs and IRQs Date: Wed, 25 Jul 2012 18:07:24 +0200 Message-ID: <501019BC.1070703@gmail.com> References: <1343202228-1507-1-git-send-email-zonque@gmail.com> <20120725160510.GA6276@core.coreip.homeip.net> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mail-wg0-f44.google.com ([74.125.82.44]:44146 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754091Ab2GYQH2 (ORCPT ); Wed, 25 Jul 2012 12:07:28 -0400 Received: by wgbdr13 with SMTP id dr13so911446wgb.1 for ; Wed, 25 Jul 2012 09:07:27 -0700 (PDT) In-Reply-To: <20120725160510.GA6276@core.coreip.homeip.net> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Dmitry Torokhov Cc: linux-input@vger.kernel.org, jhovold@gmail.com, hartleys@visionengravers.com On 25.07.2012 18:05, Dmitry Torokhov wrote: > On Wed, Jul 25, 2012 at 09:43:47AM +0200, Daniel Mack wrote: >> @@ -263,12 +243,7 @@ exit_free_mem: >> static int __devexit rotary_encoder_remove(struct platform_device *pdev) >> { >> struct rotary_encoder *encoder = platform_get_drvdata(pdev); >> - struct rotary_encoder_platform_data *pdata = pdev->dev.platform_data; >> >> - free_irq(encoder->irq_a, encoder); >> - free_irq(encoder->irq_b, encoder); >> - gpio_free(pdata->gpio_a); >> - gpio_free(pdata->gpio_b); >> input_unregister_device(encoder->input); > > Another botched devm_ conversion. *sigh* > > Input device gone, IRQ arrives, kernel goes oops, machine hangs hard. > > Please, do not use devm_ interfaces unless... Actually, just do not use > nor suggest devm_interfaces until all resources are devm-ized. Mixing 2 > styles of releasing resources leads to trouble. Ok, makes sense. Thanks for noticing. Are you happy with the first version I submitted then? Daniel