From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
David Dajun Chen <dchen@diasemi.com>
Subject: Re: [Patch v1 4/7] DA9055 GPIO driver
Date: Fri, 14 Sep 2012 18:36:48 +0530 [thread overview]
Message-ID: <50532BE8.9040905@nvidia.com> (raw)
In-Reply-To: <1347629416.18587.15.camel@dhruva>
On Friday 14 September 2012 07:00 PM, Ashish Jangam wrote:
> This is the GPIO patch for the DA9055 PMIC. This patch has got
> dependency on the DA9055 MFD core.
>
> This patch is functionally tested on SMDK6410 board.
>
> Signed-off-by: David Dajun Chen<dchen@diasemi.com>
> Signed-off-by: Ashish Jangam<ashish.jangam@kpitcummins.com>
> ---
>
> +struct da9055_gpio {
> + struct da9055 *da9055;
> + struct gpio_chip gp;
I suggest to make gp as first member so that offset of member will be 0
in container_of macro and avoid one ops.
> +static struct gpio_chip reference_gp __devinitdata = {
This is device int data and you used after device initailisation. I
think this can create issue.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next prev parent reply other threads:[~2012-09-14 13:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:30 [Patch v1 4/7] DA9055 GPIO driver Ashish Jangam
2012-09-14 13:06 ` Laxman Dewangan [this message]
2012-09-14 14:13 ` Linus Walleij
2012-09-14 16:38 ` Mark Brown
2012-10-12 9:55 ` Ashish Jangam
2012-10-12 21:17 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50532BE8.9040905@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=grant.likely@secretlab.ca \
--cc=linus.walleij@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).