From: Laxman Dewangan <ldewangan@nvidia.com>
To: Ashish Jangam <ashish.jangam@kpitcummins.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
David Dajun Chen <dchen@diasemi.com>
Subject: Re: [Patch v1 7/7] DA9055 Onkey driver
Date: Fri, 14 Sep 2012 18:48:09 +0530 [thread overview]
Message-ID: <50532E91.3020200@nvidia.com> (raw)
In-Reply-To: <1347629677.18587.21.camel@dhruva>
On Friday 14 September 2012 07:04 PM, Ashish Jangam wrote:
> +static irqreturn_t da9055_onkey_irq(int irq, void *data)
> +{
> + struct input_dev *input_dev = data;
> +
> + input_report_key(input_dev, KEY_POWER, 1);
When do you send the release key event?
Overall driver looks like you can use the gpio-key driver with passing
irq number, without passing gpio.
-----------------------------------------------------------------------------------
This email message is for the sole use of the intended recipient(s) and may contain
confidential information. Any unauthorized review, use, disclosure or distribution
is prohibited. If you are not the intended recipient, please contact the sender by
reply email and destroy all copies of the original message.
-----------------------------------------------------------------------------------
next prev parent reply other threads:[~2012-09-14 13:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-14 13:34 [Patch v1 7/7] DA9055 Onkey driver Ashish Jangam
2012-09-14 13:18 ` Laxman Dewangan [this message]
[not found] <C3AE124F08223B42BC95AEB82F0F6CED32B990D6@KCHJEXMB02.kpit.com>
2012-09-17 12:30 ` Ashish Jangam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50532E91.3020200@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=ashish.jangam@kpitcummins.com \
--cc=dchen@diasemi.com \
--cc=linux-input@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).