linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bo Shen <voice.shen@atmel.com>
To: dmitry.torokhov@gmail.com
Cc: shubhrajyoti@ti.com, linux-input@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, nicolas.ferre@atmel.com,
	jm.lin@atmel.com
Subject: Re: [PATCH v3] input: qt1070: Add device tree support
Date: Mon, 17 Sep 2012 11:34:32 +0800	[thread overview]
Message-ID: <50569A48.3080300@atmel.com> (raw)
In-Reply-To: <1347358459-11598-1-git-send-email-voice.shen@atmel.com>

Hi Dmitry,

On 9/11/2012 18:14, Bo Shen wrote:
> Add qt1070 device tree support
> Using device node to parse irq
>
> Test this on at91sam9x5ek board
>
> Signed-off-by: Bo Shen <voice.shen@atmel.com>
> ---
> change since v2
>    Using device node to parse irq,
>    Remove gpio relative stuff
>
> change since v1
>    Add gpio relative stuff, gpio_is_valid, gpio_request
> ---
>   .../devicetree/bindings/input/atmel-qt1070.txt     |   16 ++++++++++++++++
>   drivers/input/keyboard/qt1070.c                    |    9 +++++++++
>   2 files changed, 25 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/input/atmel-qt1070.txt
>

Ping?

> diff --git a/Documentation/devicetree/bindings/input/atmel-qt1070.txt b/Documentation/devicetree/bindings/input/atmel-qt1070.txt
> new file mode 100644
> index 0000000..e1fc09e
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/input/atmel-qt1070.txt
> @@ -0,0 +1,16 @@
> +Atmel qt1070 keyboard interface
> +
> +Required Properties:
> +- compatible: Should be "atmel,qt1070"
> +- reg: I2C slave address
> +- interrupt-parent: Depends on SoC
> +- interrupts: The interrupt pin number to the cpu, and trigger mode.
> +
> +Example:
> +
> +	qt1070@1b {
> +		compatible = "atmel,qt1070";
> +		reg = <0x1b>;
> +		interrupt-parent = <&pioA>;
> +		interrupts = <7 0x0>;
> +	};
> diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
> index ca68f29..60457dc 100644
> --- a/drivers/input/keyboard/qt1070.c
> +++ b/drivers/input/keyboard/qt1070.c
> @@ -249,10 +249,19 @@ static const struct i2c_device_id qt1070_id[] = {
>   };
>   MODULE_DEVICE_TABLE(i2c, qt1070_id);
>
> +#ifdef CONFIG_OF
> +static struct of_device_id atmel_qt1070_of_match[] = {
> +	{ .compatible = "atmel,qt1070" },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, atmel_qt1070_of_match);
> +#endif
> +
>   static struct i2c_driver qt1070_driver = {
>   	.driver	= {
>   		.name	= "qt1070",
>   		.owner	= THIS_MODULE,
> +		.of_match_table = of_match_ptr(atmel_qt1070_of_match),
>   	},
>   	.id_table	= qt1070_id,
>   	.probe		= qt1070_probe,
>


  reply	other threads:[~2012-09-17  3:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 10:14 [PATCH v3] input: qt1070: Add device tree support Bo Shen
2012-09-17  3:34 ` Bo Shen [this message]
     [not found] ` <1347358459-11598-1-git-send-email-voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
2012-09-17  9:20   ` Nicolas Ferre
2012-09-18  2:21     ` Bo Shen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50569A48.3080300@atmel.com \
    --to=voice.shen@atmel.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=jm.lin@atmel.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-input@vger.kernel.org \
    --cc=nicolas.ferre@atmel.com \
    --cc=shubhrajyoti@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).