From: Simon Budig <simon.budig@kernelconcepts.de>
To: Stefano Babic <sbabic@denx.de>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@vger.kernel.org, Guenter Roeck <linux@roeck-us.net>
Subject: Re: [PATCH] input: wrong irq requested in edt-ft5x06.c
Date: Thu, 20 Sep 2012 10:31:16 +0200 [thread overview]
Message-ID: <505AD454.7060200@kernelconcepts.de> (raw)
In-Reply-To: <505AD145.8050204@denx.de>
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 09/20/2012 10:18 AM, Stefano Babic wrote:
> But they contain the same information, as the irq number can be get
> easy from irq_pin with gpio_to_irq(). Having both, it is possible
> to set them to different values, and this is wrong.
gpio_to_irq is not available on all platforms. There was a discussion
on that topic quite a while ago. Moving the irq setup code to the
board file was the conclusion from that discussion.
Bye,
Simon
- --
Simon Budig kernel concepts GmbH
simon.budig@kernelconcepts.de Sieghuetter Hauptweg 48
+49-271-771091-17 D-57072 Siegen
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://www.enigmail.net/
iEYEARECAAYFAlBa1FQACgkQO2O/RXesiHDBOACfamvKFxTYUR9TdVSLhTobthoG
KKwAniPJtTiufxLrATH+n8DwlzuPsok0
=QqF7
-----END PGP SIGNATURE-----
next prev parent reply other threads:[~2012-09-20 8:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-19 14:53 [PATCH] input: wrong irq requested in edt-ft5x06.c Stefano Babic
2012-09-19 16:58 ` Dmitry Torokhov
2012-09-20 8:18 ` Stefano Babic
2012-09-20 8:31 ` Simon Budig [this message]
2012-09-20 8:56 ` Stefano Babic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=505AD454.7060200@kernelconcepts.de \
--to=simon.budig@kernelconcepts.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sbabic@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).