* [PATCH] Input: Add Alps touchpad 73 03 0a support
@ 2012-10-03 2:37 Pavel Bludov
2012-10-04 7:25 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Pavel Bludov @ 2012-10-03 2:37 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input
Hi Dmitry,
the patch is trivial:
E7 report is 73 03 0a
command mode response is 88 08 1c
absolute mode controlled by register c2c4
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index cf5af1f..1b640f2 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -112,6 +112,7 @@ static const struct alps_model_info
alps_model_data[] = {
{ { 0x73, 0x02, 0x64 }, 0x9b, ALPS_PROTO_V3, 0x8f, 0x8f,
ALPS_DUALPOINT },
{ { 0x73, 0x02, 0x64 }, 0x9d, ALPS_PROTO_V3, 0x8f, 0x8f,
ALPS_DUALPOINT },
{ { 0x73, 0x02, 0x64 }, 0x8a, ALPS_PROTO_V4, 0x8f, 0x8f, 0 },
+ { { 0x73, 0x03, 0x0a }, 0x1c, ALPS_PROTO_V3, 0x8f, 0x8f, 0 },
};
/*
@@ -983,7 +984,7 @@ static int alps_enter_command_mode(struct psmouse
*psmouse,
return -1;
}
- if (param[0] != 0x88 && param[1] != 0x07) {
+ if (param[0] != 0x88 && param[1] != 0x07 && param[1] != 0x08) {
psmouse_dbg(psmouse,
"unknown response while entering command
mode: %2.2x %2.2x %2.2x\n",
param[0], param[1], param[2]);
@@ -1302,6 +1303,12 @@ static int alps_hw_init_v3(struct psmouse *psmouse)
if (alps_enter_command_mode(psmouse, NULL))
goto error;
+ reg_val = alps_command_mode_read_reg(psmouse, 0xc2c8);
+ if (reg_val == 0) {
+ if (alps_command_mode_write_reg(psmouse, 0xc2c4, 0x02))
+ goto error;
+ }
+
/* Check for trackstick */
reg_val = alps_command_mode_read_reg(psmouse, 0x0008);
if (reg_val == -1)
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Input: Add Alps touchpad 73 03 0a support
2012-10-03 2:37 [PATCH] Input: Add Alps touchpad 73 03 0a support Pavel Bludov
@ 2012-10-04 7:25 ` Dmitry Torokhov
2012-10-06 5:37 ` [PATCHv2] " Pavel Bludov
0 siblings, 1 reply; 3+ messages in thread
From: Dmitry Torokhov @ 2012-10-04 7:25 UTC (permalink / raw)
To: Pavel Bludov; +Cc: linux-input
Hi Pavel,
On Wed, Oct 03, 2012 at 11:37:50AM +0900, Pavel Bludov wrote:
> Hi Dmitry,
> the patch is trivial:
>
> E7 report is 73 03 0a
> command mode response is 88 08 1c
> absolute mode controlled by register c2c4
It looks like you mailer mangled the patch by line-wrapping it, and I
would also need your "Signed-off-by: ..." to be able to apply the patch.
Thanks!
>
> diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
> index cf5af1f..1b640f2 100644
> --- a/drivers/input/mouse/alps.c
> +++ b/drivers/input/mouse/alps.c
> @@ -112,6 +112,7 @@ static const struct alps_model_info
> alps_model_data[] = {
> { { 0x73, 0x02, 0x64 }, 0x9b, ALPS_PROTO_V3, 0x8f, 0x8f,
> ALPS_DUALPOINT },
> { { 0x73, 0x02, 0x64 }, 0x9d, ALPS_PROTO_V3, 0x8f, 0x8f,
> ALPS_DUALPOINT },
> { { 0x73, 0x02, 0x64 }, 0x8a, ALPS_PROTO_V4, 0x8f, 0x8f, 0 },
> + { { 0x73, 0x03, 0x0a }, 0x1c, ALPS_PROTO_V3, 0x8f, 0x8f, 0 },
> };
>
> /*
> @@ -983,7 +984,7 @@ static int alps_enter_command_mode(struct
> psmouse *psmouse,
> return -1;
> }
>
> - if (param[0] != 0x88 && param[1] != 0x07) {
> + if (param[0] != 0x88 && param[1] != 0x07 && param[1] != 0x08) {
> psmouse_dbg(psmouse,
> "unknown response while entering command
> mode: %2.2x %2.2x %2.2x\n",
> param[0], param[1], param[2]);
> @@ -1302,6 +1303,12 @@ static int alps_hw_init_v3(struct psmouse *psmouse)
> if (alps_enter_command_mode(psmouse, NULL))
> goto error;
>
> + reg_val = alps_command_mode_read_reg(psmouse, 0xc2c8);
> + if (reg_val == 0) {
> + if (alps_command_mode_write_reg(psmouse, 0xc2c4, 0x02))
> + goto error;
> + }
> +
> /* Check for trackstick */
> reg_val = alps_command_mode_read_reg(psmouse, 0x0008);
> if (reg_val == -1)
>
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCHv2] Input: Add Alps touchpad 73 03 0a support
2012-10-04 7:25 ` Dmitry Torokhov
@ 2012-10-06 5:37 ` Pavel Bludov
0 siblings, 0 replies; 3+ messages in thread
From: Pavel Bludov @ 2012-10-06 5:37 UTC (permalink / raw)
To: Dmitry Torokhov; +Cc: linux-input
04.10.2012 16:25, Dmitry Torokhov wrote:
> It looks like you mailer mangled the patch by line-wrapping it, and I
> would also need your "Signed-off-by: ..." to be able to apply the patch.
Thank you for your patience, Dmitry!
I have throughly read
http://www.kernel.org/doc/Documentation/SubmittingPatches
http://kb.mozillazine.org/Plain_text_e-mail_%28Thunderbird%29
and there is a new version:
Support for alps touchpad found in Intel Latexo notebook.
E7 report is 73 03 0a
command mode response is 88 08 1c
absolute mode controlled by register c2c4
Tested on Intel Latexo with 3.6 kernel.
Signed-off-by: Pavel Bludov <pbludov@gmail.com>
diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c
index cf5af1f..1b640f2 100644
--- a/drivers/input/mouse/alps.c
+++ b/drivers/input/mouse/alps.c
@@ -112,6 +112,7 @@ static const struct alps_model_info alps_model_data[] = {
{ { 0x73, 0x02, 0x64 }, 0x9b, ALPS_PROTO_V3, 0x8f, 0x8f, ALPS_DUALPOINT },
{ { 0x73, 0x02, 0x64 }, 0x9d, ALPS_PROTO_V3, 0x8f, 0x8f, ALPS_DUALPOINT },
{ { 0x73, 0x02, 0x64 }, 0x8a, ALPS_PROTO_V4, 0x8f, 0x8f, 0 },
+ { { 0x73, 0x03, 0x0a }, 0x1c, ALPS_PROTO_V3, 0x8f, 0x8f, 0 },
};
/*
@@ -983,7 +984,7 @@ static int alps_enter_command_mode(struct psmouse *psmouse,
return -1;
}
- if (param[0] != 0x88 && param[1] != 0x07) {
+ if (param[0] != 0x88 && param[1] != 0x07 && param[1] != 0x08) {
psmouse_dbg(psmouse,
"unknown response while entering command mode: %2.2x %2.2x %2.2x\n",
param[0], param[1], param[2]);
@@ -1302,6 +1303,12 @@ static int alps_hw_init_v3(struct psmouse *psmouse)
if (alps_enter_command_mode(psmouse, NULL))
goto error;
+ reg_val = alps_command_mode_read_reg(psmouse, 0xc2c8);
+ if (reg_val == 0) {
+ if (alps_command_mode_write_reg(psmouse, 0xc2c4, 0x02))
+ goto error;
+ }
+
/* Check for trackstick */
reg_val = alps_command_mode_read_reg(psmouse, 0x0008);
if (reg_val == -1)
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-10-06 5:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-10-03 2:37 [PATCH] Input: Add Alps touchpad 73 03 0a support Pavel Bludov
2012-10-04 7:25 ` Dmitry Torokhov
2012-10-06 5:37 ` [PATCHv2] " Pavel Bludov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).