Re: [PATCH v2] iio: exynos-adc: add experimental touchscreen support

Arnd Bergmann
2014-07-22T18:33:44Z

On Tuesday 22 July 2014 11:09:04 Dmitry Torokhov wrote:
> > @@ -565,6 +722,15 @@ static int exynos_adc_probe(struct platform_device *pdev)
> > if (info->data->init_hw)
> > info->data->init_hw(info);
> >
> > + /* leave out any TS related code if unreachable */
> > + if (IS_BUILTIN(CONFIG_INPUT) ||
> > + (IS_MODULE(CONFIG_INPUT) && config_enabled(MODULE)))
>
> This is ugly... We need IS_SUBSYSTEM_AVAILABLE() wrapper for this...
>
> Anyway,
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
>

I actually have a patch to introduce IS_REACHABLE() for this purpose,
but I haven't sent it out for review yet. The main user of this would
be drivers/media, which had the correct logic earlier until someone
tried to "simplify" it by replacing it all with IS_ENABLED()...

Arnd