From: Stephen Warren <swarren@wwwdotorg.org>
To: AnilKumar Ch <anilkumar@ti.com>
Cc: dmitry.torokhov@gmail.com, grant.likely@secretlab.ca,
devicetree-discuss@lists.ozlabs.org, dgdunix@gmail.com,
rob.herring@calxeda.com, linux-input@vger.kernel.org
Subject: Re: [PATCH v2] Input: matrix-keypad - Add device tree support
Date: Wed, 31 Oct 2012 09:30:59 -0600 [thread overview]
Message-ID: <50914433.1070805@wwwdotorg.org> (raw)
In-Reply-To: <1351684471-29369-1-git-send-email-anilkumar@ti.com>
On 10/31/2012 05:54 AM, AnilKumar Ch wrote:
> Add device tree support to matrix keypad driver and usage details
> are added to device tree documentation. Driver was tested on AM335x
> EVM.
> diff --git a/Documentation/devicetree/bindings/input/matrix-keypad.txt b/Documentation/devicetree/bindings/input/matrix-keypad.txt
> new file mode 100644
> +- compatible: Should be "gpio-matix-keypad"
There's a typo there.
Given that compatible value, shouldn't the file be named
gpio-matrix-keypad.txt then?
It seems like the property linux,keymap should be mentioned here too,
with a note to read matrix-keymap.txt for the definition.
> +Optional Properties:
> +- clustered-irq: have clustered irq number
> +- clustered-irq-flags: have clustered irq flags
Explaining what those mean would be useful.
next prev parent reply other threads:[~2012-10-31 15:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-31 11:54 [PATCH v2] Input: matrix-keypad - Add device tree support AnilKumar Ch
2012-10-31 15:30 ` Stephen Warren [this message]
2012-11-02 8:21 ` AnilKumar, Chimata
2012-11-02 15:03 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50914433.1070805@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=anilkumar@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dgdunix@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-input@vger.kernel.org \
--cc=rob.herring@calxeda.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).