From: "Adrian McMenamin" <adrian@newgolddream.dyndns.info>
To: Paul Mundt <lethal@linux-sh.org>,
Adrian McMenamin <adrian@newgolddream.dyndns.info>,
Greg KH <greg@kroah.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>, dwmw2 <dwmw2@in>
Subject: Re: [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3)
Date: Thu, 29 Jan 2009 10:34:43 -0000 (UTC) [thread overview]
Message-ID: <509354d63a44246cefe01bd35eb1374c.squirrel@newgolddream.dyndns.info> (raw)
In-Reply-To: <20090129025754.GC31096@linux-sh.org>
On Thu, January 29, 2009 2:57 am, Paul Mundt wrote:
> On Thu, Jan 29, 2009 at 12:18:07AM +0000, Adrian McMenamin wrote:
>> + if (!(mdev->function & MAPLE_FUNC_KEYBOARD)) {
>> + error = EINVAL;
>> + goto fail;
>> + }
>>
> What is this all about? If the function doesn't match, you should never
> enter the probe routine in the first place. The bus code should already
> get this right.
>
It does, it is a fragment of old code from when the bus code was wrong
which for reasons which pass understanding I rewrote rather than just
excised.
next prev parent reply other threads:[~2009-01-29 10:35 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-28 23:47 [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (0/3) Adrian McMenamin
2009-01-28 23:57 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (1/3) Adrian McMenamin
2009-01-29 0:09 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (2/3) Adrian McMenamin
2009-01-29 0:18 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (3/3) Adrian McMenamin
2009-01-29 2:57 ` Paul Mundt
2009-01-29 10:34 ` Adrian McMenamin [this message]
2009-01-29 5:46 ` Mike Frysinger
2009-01-29 0:44 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (2/3) Mike Frysinger
2009-01-29 0:49 ` Adrian McMenamin
2009-01-29 1:12 ` Mike Frysinger
2009-01-29 0:42 ` [PATCH RFC] sh: maple: Add support for SEGA Dreamcast VMU and clean up maple bus driver (1/3) Mike Frysinger
2009-01-29 3:13 ` Paul Mundt
2009-01-29 16:43 ` Adrian McMenamin
[not found] ` <3ca9ec7a13c1a13ea7be6c37bbdfdb0c.squirrel@newgolddream.dyndns.info>
2009-01-29 16:51 ` Adrian McMenamin
2009-01-30 9:55 ` Adrian McMenamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=509354d63a44246cefe01bd35eb1374c.squirrel@newgolddream.dyndns.info \
--to=adrian@newgolddream.dyndns.info \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@in \
--cc=greg@kroah.com \
--cc=lethal@linux-sh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).