From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christopher Heiny <cheiny@synaptics.com>
Subject: Re: [RFC PATCH 02/06] input/rmi4: Core files
Date: Mon, 19 Nov 2012 20:56:12 -0800
Message-ID: <50AB0D6C.9040003@synaptics.com>
References: <1353124734-16803-1-git-send-email-cheiny@synaptics.com> <1353124734-16803-3-git-send-email-cheiny@synaptics.com> <20121117215415.GA5624@kroah.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
Return-path: <linux-input-owner@vger.kernel.org>
Received: from us-mx3.synaptics.com ([12.239.217.85]:62364 "EHLO
	us-mx3.synaptics.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750770Ab2KTE4O (ORCPT
	<rfc822;linux-input@vger.kernel.org>);
	Mon, 19 Nov 2012 23:56:14 -0500
In-Reply-To: <20121117215415.GA5624@kroah.com>
Sender: linux-input-owner@vger.kernel.org
List-Id: linux-input@vger.kernel.org
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, Jean Delvare <khali@linux-fr.org>, Linux Kernel <linux-kernel@vger.kernel.org>, Linux Input <linux-input@vger.kernel.org>, Allie Xiong <axiong@synaptics.com>, Vivian Ly <vly@synaptics.com>, Daniel Rosenberg <daniel.rosenberg@synaptics.com>, Alexandra Chin <alexandra.chin@tw.synaptics.com>, Joerie de Gram <j.de.gram@gmail.com>, Wolfram Sang <w.sang@pengutronix.de>, Mathieu Poirier <mathieu.poirier@linaro.org>, Linus Walleij <linus.walleij@stericsson.com>, Naveen Kumar Gaddipati <naveen.gaddipati@stericsson.com>

On 11/17/2012 01:54 PM, Greg Kroah-Hartman wrote:
> On Fri, Nov 16, 2012 at 07:58:50PM -0800, Christopher Heiny wrote:
>> +static void release_rmidev_device(struct device *dev)
>> +{
>> +	device_unregister(dev);
>> +}
>
> You just leaked memory here, right?
>
> Also, you already unregistered the device, otherwise this function would
> have never been called, so you just ended up in a loop?

Roger.  We'll fix that.


> Have you ever tried removing a device?  Are you sure it's working
> properly?

Hmmmm.  If it leads to the loop you mention above, then the test I'm 
using must not be doing what I thought it was.  I'll fix that, too.


>> +EXPORT_SYMBOL(rmi_register_phys_device);
>
> Just curious, but why not EXPORT_SYMBOL_GPL() on all of these new
> symbols you are creating?

We'll change that.

				Thanks very much!
						Chris