From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>, jic23@kernel.org
Cc: Sachin Kamat <sachin.kamat@linaro.org>,
linux-input@vger.kernel.org, jkosina@suse.cz, patches@linaro.org
Subject: Re: [PATCH 2/2] hid: hid-sensor-hub: Move NULL check to beginning
Date: Wed, 21 Nov 2012 09:11:39 -0800 [thread overview]
Message-ID: <50AD0B4B.10109@linux.intel.com> (raw)
In-Reply-To: <20121121124251.7bc7102b@pyramind.ukuu.org.uk>
Hi Jonathan,
Please check and merge Alan Cox's patch. I have forwarded this patch to you.
Thanks,
Srinivas
On 11/21/2012 04:42 AM, Alan Cox wrote:
> On Wed, 21 Nov 2012 11:50:30 +0530
> Sachin Kamat <sachin.kamat@linaro.org> wrote:
>
>> This avoids a possible NULL pointer dereference error when report
>> is NULL.
> This is wrong. Please see the patch I sent a while ago - it can't be
> NULL, the check just needs removing.
>
next prev parent reply other threads:[~2012-11-21 17:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 6:20 [PATCH 1/2] hid: usbhid: Return -ENOMEM instead of -1 for memory allocation failure Sachin Kamat
2012-11-21 6:20 ` [PATCH 2/2] hid: hid-sensor-hub: Move NULL check to beginning Sachin Kamat
2012-11-21 12:42 ` Alan Cox
2012-11-21 17:11 ` Srinivas Pandruvada [this message]
2012-11-21 22:26 ` Jiri Kosina
2012-11-22 21:03 ` [PATCH 1/2] hid: usbhid: Return -ENOMEM instead of -1 for memory allocation failure Jiri Kosina
2012-11-26 18:05 ` Dmitry Torokhov
2012-11-26 22:09 ` Jiri Kosina
2012-11-27 4:42 ` Sachin Kamat
2012-11-27 9:55 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AD0B4B.10109@linux.intel.com \
--to=srinivas.pandruvada@linux.intel.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jic23@kernel.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=patches@linaro.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).