From mboxrd@z Thu Jan 1 00:00:00 1970 From: Srinivas Pandruvada Subject: Re: [PATCH 2/2] hid: hid-sensor-hub: Move NULL check to beginning Date: Wed, 21 Nov 2012 09:11:39 -0800 Message-ID: <50AD0B4B.10109@linux.intel.com> References: <1353478830-23788-1-git-send-email-sachin.kamat@linaro.org> <1353478830-23788-2-git-send-email-sachin.kamat@linaro.org> <20121121124251.7bc7102b@pyramind.ukuu.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from mga09.intel.com ([134.134.136.24]:59653 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753318Ab2KURKu (ORCPT ); Wed, 21 Nov 2012 12:10:50 -0500 In-Reply-To: <20121121124251.7bc7102b@pyramind.ukuu.org.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Alan Cox , jic23@kernel.org Cc: Sachin Kamat , linux-input@vger.kernel.org, jkosina@suse.cz, patches@linaro.org Hi Jonathan, Please check and merge Alan Cox's patch. I have forwarded this patch to you. Thanks, Srinivas On 11/21/2012 04:42 AM, Alan Cox wrote: > On Wed, 21 Nov 2012 11:50:30 +0530 > Sachin Kamat wrote: > >> This avoids a possible NULL pointer dereference error when report >> is NULL. > This is wrong. Please see the patch I sent a while ago - it can't be > NULL, the check just needs removing. >