From: Laxman Dewangan <ldewangan@nvidia.com>
To: Stephen Warren <swarren@wwwdotorg.org>
Cc: "dmitry.torokhov@gmail.com" <dmitry.torokhov@gmail.com>,
"grant.likely@secretlab.ca" <grant.likely@secretlab.ca>,
"rob.herring@calxeda.com" <rob.herring@calxeda.com>,
Stephen Warren <swarren@nvidia.com>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>
Subject: Re: [PATCH 4/4] input: keyboard: tegra: remove default key mapping
Date: Sat, 5 Jan 2013 12:50:50 +0530 [thread overview]
Message-ID: <50E7D452.8030208@nvidia.com> (raw)
In-Reply-To: <50E7330D.2060107@wwwdotorg.org>
On Saturday 05 January 2013 01:22 AM, Stephen Warren wrote:
> On 01/04/2013 04:02 AM, Laxman Dewangan wrote:
>> Tegra KBC driver have the default key mapping for 16x8 configuration.
>> The key mapping can be provided through platform data or through DT
>> and the mapping varies from platform to platform, hence this default
>> mapping is not so useful. Remove the default mapping to reduce the code
>> lines of the driver.
> Overall, I agree with the intent of this change, but I /think/ the
> default keymap described here actually /is/ useful for the
> Seaboard/Springbank platforms. I guess the KBC driver isn't in the
> device tree for that (or any) board yet, so removing this keymap isn't
> really a regression, but it would be nice if you could come up with a
> change to add suitable keymaps to the device tree files too.
OK, I will push the patch for enabling keys in seaboard along with the
other changes for DT files for tegra.
next prev parent reply other threads:[~2013-01-05 7:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 11:02 [PATCH 0/4] input: keyboard: tegra: cleanups and DT supports Laxman Dewangan
[not found] ` <1357297330-28878-1-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-04 11:02 ` [PATCH 1/4] input: keyboard: tegra: fix build warning Laxman Dewangan
2013-01-04 11:02 ` [PATCH 2/4] input: keyboard: tegra: use devm_* for resource allocation Laxman Dewangan
2013-01-04 11:02 ` [PATCH 4/4] input: keyboard: tegra: remove default key mapping Laxman Dewangan
[not found] ` <1357297330-28878-5-git-send-email-ldewangan-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2013-01-04 19:52 ` Stephen Warren
2013-01-05 7:20 ` Laxman Dewangan [this message]
2013-01-04 11:02 ` [PATCH 3/4] input: keyboard: tegra: add support for rows/cols configuration from dt Laxman Dewangan
2013-01-04 19:50 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50E7D452.8030208@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dmitry.torokhov@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=rob.herring@calxeda.com \
--cc=swarren@nvidia.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).