From: vipul kumar samar <vipulkumar.samar@st.com>
To: Viresh Kumar <viresh.kumar@linaro.org>, Marek Vasut <marex@denx.de>
Cc: Lee Jones <lee.jones@linaro.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Samuel Ortiz <sameo@linux.intel.com>
Subject: Re: [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe
Date: Tue, 8 Jan 2013 09:22:03 +0530 [thread overview]
Message-ID: <50EB97E3.8050703@st.com> (raw)
In-Reply-To: <CAKohpon_h2ehq5Cf-fVyne33y7iyXCD35FVV1yuhgoDDstEcFQ@mail.gmail.com>
On 1/7/2013 11:49 PM, Viresh Kumar wrote:
> On 7 January 2013 20:43, Marek Vasut<marex@denx.de> wrote:
>>>> The new
>>>> behaviour is the expected one and copies the behavior of
>>>> platform_data-based probe.
>>>
>>> Blindly copying platform data behaviour to DT bindings is seldom a good
>>> idea.
>>
>> Do you have suggestions how to pass these information? I suspect the irq-over-
>> gpio property can be killed, since if irq-gpios prop is there, it implies irq-
>> over-gpio anyway.
>
> Both can be killed. gpios as interrupt lines can be requested as:
>
> interrupt-parent =<&gpio-controller>;
> interrupts =<25 0x1>;
>
> and probably the stmpe driver doesn't have to bother at all if
> interrupt was over gpio
> or not.
> .
>
Yes, both can be killed and similarly we did for spear1340 machine but
some how we missed it on spear320-hmi.
Regards
Vipul Samar
next prev parent reply other threads:[~2013-01-08 3:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 14:29 [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe Marek Vasut
2013-01-07 15:03 ` Lee Jones
2013-01-07 15:13 ` Marek Vasut
2013-01-07 15:44 ` Lee Jones
2013-01-07 18:19 ` Viresh Kumar
2013-01-08 3:52 ` vipul kumar samar [this message]
2013-01-08 9:41 ` Lee Jones
2013-01-08 9:44 ` Marek Vasut
2013-01-08 9:48 ` Marek Vasut
2013-01-08 10:47 ` Viresh Kumar
2013-01-08 11:11 ` Lee Jones
2013-01-08 11:14 ` Viresh Kumar
2013-01-08 11:18 ` Laxman Dewangan
2013-01-08 11:23 ` Viresh Kumar
2013-01-10 11:42 ` Linus Walleij
2013-01-10 12:57 ` Lee Jones
2013-02-08 22:51 ` Grant Likely
2013-02-14 16:26 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50EB97E3.8050703@st.com \
--to=vipulkumar.samar@st.com \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-input@vger.kernel.org \
--cc=marex@denx.de \
--cc=sameo@linux.intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).