From mboxrd@z Thu Jan 1 00:00:00 1970 From: vipul kumar samar Subject: Re: [PATCH] mfd: stmpe: Pull IRQ GPIO number from DT during DT-based probe Date: Tue, 8 Jan 2013 09:22:03 +0530 Message-ID: <50EB97E3.8050703@st.com> References: <1357568989-16237-1-git-send-email-marex@denx.de> <20130107150341.GT21994@gmail.com> <201301071613.33573.marex@denx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Return-path: Received: from eu1sys200aog105.obsmtp.com ([207.126.144.119]:43447 "EHLO eu1sys200aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751359Ab3AHDwY (ORCPT ); Mon, 7 Jan 2013 22:52:24 -0500 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Viresh Kumar , Marek Vasut Cc: Lee Jones , "linux-arm-kernel@lists.infradead.org" , "linux-input@vger.kernel.org" , Linus Walleij , Samuel Ortiz On 1/7/2013 11:49 PM, Viresh Kumar wrote: > On 7 January 2013 20:43, Marek Vasut wrote: >>>> The new >>>> behaviour is the expected one and copies the behavior of >>>> platform_data-based probe. >>> >>> Blindly copying platform data behaviour to DT bindings is seldom a good >>> idea. >> >> Do you have suggestions how to pass these information? I suspect the irq-over- >> gpio property can be killed, since if irq-gpios prop is there, it implies irq- >> over-gpio anyway. > > Both can be killed. gpios as interrupt lines can be requested as: > > interrupt-parent =<&gpio-controller>; > interrupts =<25 0x1>; > > and probably the stmpe driver doesn't have to bother at all if > interrupt was over gpio > or not. > . > Yes, both can be killed and similarly we did for spear1340 machine but some how we missed it on spear320-hmi. Regards Vipul Samar