* [PATCH] HID: holtek: Holtek devices depends on USB_HID
@ 2013-03-07 9:48 Benjamin Tissoires
2013-03-07 14:28 ` Jiri Kosina
2013-03-08 20:52 ` Randy Dunlap
0 siblings, 2 replies; 5+ messages in thread
From: Benjamin Tissoires @ 2013-03-07 9:48 UTC (permalink / raw)
To: Benjamin Tissoires, Jiri Kosina, linux-input, linux-kernel
Cc: Benjamin Tissoires
In the HID drivers tranport cleanup series, I removed the dependency
between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
extensively on usb calls.
This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
---
drivers/hid/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index 3abb11f..613083a 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -215,7 +215,7 @@ config HID_EZKEY
config HID_HOLTEK
tristate "Holtek HID devices"
- depends on HID
+ depends on USB_HID
---help---
Support for Holtek based devices:
- Holtek On Line Grip based game controller
--
1.8.1.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID
2013-03-07 9:48 [PATCH] HID: holtek: Holtek devices depends on USB_HID Benjamin Tissoires
@ 2013-03-07 14:28 ` Jiri Kosina
2013-03-08 20:52 ` Randy Dunlap
1 sibling, 0 replies; 5+ messages in thread
From: Jiri Kosina @ 2013-03-07 14:28 UTC (permalink / raw)
To: Benjamin Tissoires; +Cc: Benjamin Tissoires, linux-input, linux-kernel
On Thu, 7 Mar 2013, Benjamin Tissoires wrote:
> In the HID drivers tranport cleanup series, I removed the dependency
> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
> extensively on usb calls.
>
> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
Applied.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID
2013-03-07 9:48 [PATCH] HID: holtek: Holtek devices depends on USB_HID Benjamin Tissoires
2013-03-07 14:28 ` Jiri Kosina
@ 2013-03-08 20:52 ` Randy Dunlap
2013-03-08 21:00 ` Jiri Kosina
1 sibling, 1 reply; 5+ messages in thread
From: Randy Dunlap @ 2013-03-08 20:52 UTC (permalink / raw)
To: Benjamin Tissoires
Cc: Benjamin Tissoires, Jiri Kosina, linux-input, linux-kernel
On 03/07/13 01:48, Benjamin Tissoires wrote:
> In the HID drivers tranport cleanup series, I removed the dependency
> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
> extensively on usb calls.
>
> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
>
> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
ERROR: "usb_control_msg" [drivers/hid/hid-multitouch.ko] undefined!
> ---
> drivers/hid/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 3abb11f..613083a 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -215,7 +215,7 @@ config HID_EZKEY
>
> config HID_HOLTEK
> tristate "Holtek HID devices"
> - depends on HID
> + depends on USB_HID
> ---help---
> Support for Holtek based devices:
> - Holtek On Line Grip based game controller
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID
2013-03-08 20:52 ` Randy Dunlap
@ 2013-03-08 21:00 ` Jiri Kosina
2013-03-08 21:10 ` Randy Dunlap
0 siblings, 1 reply; 5+ messages in thread
From: Jiri Kosina @ 2013-03-08 21:00 UTC (permalink / raw)
To: Randy Dunlap
Cc: Benjamin Tissoires, Benjamin Tissoires, linux-input, linux-kernel
On Fri, 8 Mar 2013, Randy Dunlap wrote:
> > In the HID drivers tranport cleanup series, I removed the dependency
> > between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
> > extensively on usb calls.
> >
> > This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
> >
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>
> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>
>
> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH,
hence that shouldn't be a problem.
There used to be a problem in linux-next, but that should be fixed by
4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have
pushed out yesterday.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID
2013-03-08 21:00 ` Jiri Kosina
@ 2013-03-08 21:10 ` Randy Dunlap
0 siblings, 0 replies; 5+ messages in thread
From: Randy Dunlap @ 2013-03-08 21:10 UTC (permalink / raw)
To: Jiri Kosina
Cc: Benjamin Tissoires, Benjamin Tissoires, linux-input, linux-kernel
On 03/08/13 13:00, Jiri Kosina wrote:
> On Fri, 8 Mar 2013, Randy Dunlap wrote:
>
>>> In the HID drivers tranport cleanup series, I removed the dependency
>>> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
>>> extensively on usb calls.
>>>
>>> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
>>>
>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>>
>> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
>
> Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH,
> hence that shouldn't be a problem.
You are correct. I was testing 3.9-rc1 + mmotm, where the latter contains
some incorrect HID patches (from linux-next).
Thanks.
> There used to be a problem in linux-next, but that should be fixed by
> 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have
> pushed out yesterday.
>
--
~Randy
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-08 21:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-03-07 9:48 [PATCH] HID: holtek: Holtek devices depends on USB_HID Benjamin Tissoires
2013-03-07 14:28 ` Jiri Kosina
2013-03-08 20:52 ` Randy Dunlap
2013-03-08 21:00 ` Jiri Kosina
2013-03-08 21:10 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).