From: Randy Dunlap <rdunlap@infradead.org>
To: Jiri Kosina <jkosina@suse.cz>
Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: holtek: Holtek devices depends on USB_HID
Date: Fri, 08 Mar 2013 13:10:33 -0800 [thread overview]
Message-ID: <513A53C9.6020606@infradead.org> (raw)
In-Reply-To: <alpine.LNX.2.00.1303082159140.19460@pobox.suse.cz>
On 03/08/13 13:00, Jiri Kosina wrote:
> On Fri, 8 Mar 2013, Randy Dunlap wrote:
>
>>> In the HID drivers tranport cleanup series, I removed the dependency
>>> between hid-holtek and usbhid. This was wrong as hid-holtek.c relies
>>> extensively on usb calls.
>>>
>>> This fixes compilation error when CONFIG_USB_SUPPORT is not enabled.
>>>
>>> Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
>>
>> Acked-by: Randy Dunlap <rdunlap@infradead.org>
>>
>>
>> but hid-multitouch build still fails (on 3.9-rc1) when USB_SUPPORT is not enabled:
>
> Are you sure about 3.9-rc1? It has USB_HID dependency for HID_MUTLTIOUCH,
> hence that shouldn't be a problem.
You are correct. I was testing 3.9-rc1 + mmotm, where the latter contains
some incorrect HID patches (from linux-next).
Thanks.
> There used to be a problem in linux-next, but that should be fixed by
> 4ba25d3f87 ("HID: multitouch: remove last usb dependency"), which I have
> pushed out yesterday.
>
--
~Randy
prev parent reply other threads:[~2013-03-08 21:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-07 9:48 [PATCH] HID: holtek: Holtek devices depends on USB_HID Benjamin Tissoires
2013-03-07 14:28 ` Jiri Kosina
2013-03-08 20:52 ` Randy Dunlap
2013-03-08 21:00 ` Jiri Kosina
2013-03-08 21:10 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=513A53C9.6020606@infradead.org \
--to=rdunlap@infradead.org \
--cc=benjamin.tissoires@gmail.com \
--cc=benjamin.tissoires@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).