From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benjamin Tissoires Subject: Re: [PATCH v3.7+] HID: magicmouse: fix race between input_register() and probe() Date: Thu, 04 Apr 2013 09:52:10 +0200 Message-ID: <515D312A.8000909@redhat.com> References: <1364893912-29578-1-git-send-email-benjamin.tissoires@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from mx1.redhat.com ([209.132.183.28]:62123 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763871Ab3DDHw5 (ORCPT ); Thu, 4 Apr 2013 03:52:57 -0400 In-Reply-To: Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Jiri Kosina Cc: Benjamin Tissoires , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org On 04/04/2013 09:51 AM, Jiri Kosina wrote: > On Tue, 2 Apr 2013, Benjamin Tissoires wrote: > >> Since kernel 3.7, it appears that the input registration occured before >> the end of magicmouse_setup_input(). This is shown by receiving a lot of >> "EV_SYN SYN_REPORT 1" instead of normal "EV_SYN SYN_REPORT 0". >> This value means that the output buffer is full, and the user space >> is loosing events. >> >> Using .input_configured guarantees that the race is not occuring, and that >> the call of "input_set_events_per_packet(input, 60)" is taken into account >> by input_register(). >> >> Fixes: >> https://bugzilla.redhat.com/show_bug.cgi?id=908604 >> >> Reported-and-Tested-By: Clarke Wixon >> Signed-off-by: Benjamin Tissoires >> --- >> >> Hi Jiri, >> >> this one can goes to stable (so 3.8) as well. > > Applied, and will push for 3.9 still. Ok, thanks Jiri. Cheers, Benjamin > > Thanks. >