From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Oliver Neukum <oneukum@suse.de>
Cc: Jiri Kosina <jkosina@suse.cz>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Benjamin Tissoires <benjamin.tissoires@gmail.com>,
Bastien Nocera <hadess@hadess.net>,
Fabien <fabien.andre@gmail.com>, Jarod Wilson <jarod@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] HID: appleir: add support for Apple ir devices
Date: Wed, 17 Apr 2013 18:07:37 +0200 [thread overview]
Message-ID: <516EC8C9.8040000@redhat.com> (raw)
In-Reply-To: <1614985.S6T7jXBLvD@linux-5eaq.site>
On 04/17/2013 12:30 PM, Oliver Neukum wrote:
> On Wednesday 17 April 2013 11:03:09 Benjamin Tissoires wrote:
>
>> +static void appleir_remove(struct hid_device *hid)
>> +{
>> + struct appleir *appleir = hid_get_drvdata(hid);
>> + del_timer_sync(&appleir->key_up_timer);
>> + hid_hw_stop(hid);
>> + kfree(appleir);
>> +}
>
> Hi,
>
> this looks like a race condition. If you get input between
> del_timer_sync() and hid_hw_stop() the timer may be restarted.
> You need to stop the hw first.
>
ouch. Thanks for spotting this.
Will send a v3 soon.
Cheers,
Benjamin
prev parent reply other threads:[~2013-04-17 16:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-17 9:03 [PATCH v2] HID: appleir: add support for Apple ir devices Benjamin Tissoires
2013-04-17 10:30 ` Oliver Neukum
2013-04-17 16:07 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=516EC8C9.8040000@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=benjamin.tissoires@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=fabien.andre@gmail.com \
--cc=hadess@hadess.net \
--cc=jarod@redhat.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oneukum@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).