From: Benjamin Tissoires <benjamin.tissoires@redhat.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Jiri Kosina <jkosina@suse.cz>, linux-input@vger.kernel.org
Subject: Re: [PATCH 2/2] hid: remove duplicate for D-WAV eGalax 0x7224
Date: Tue, 07 May 2013 16:46:07 +0200 [thread overview]
Message-ID: <518913AF.7000800@redhat.com> (raw)
In-Reply-To: <1367937287.29283.21.camel@smile>
On 05/07/2013 04:34 PM, Andy Shevchenko wrote:
> On Tue, 2013-05-07 at 17:29 +0300, Andy Shevchenko wrote:
>> There is actually not clear which driver_data ahall be used.
>>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/hid/hid-ids.h | 1 -
>> drivers/hid/hid-multitouch.c | 3 ---
>> 2 files changed, 4 deletions(-)
>>
>> diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
>> index 2378a0b..a5520ba 100644
>> --- a/drivers/hid/hid-ids.h
>> +++ b/drivers/hid/hid-ids.h
>> @@ -268,7 +268,6 @@
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7207 0x7207
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_720C 0x720c
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224
>> -#define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224 0x7224
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A 0x722A
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_725E 0x725e
>> #define USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7262 0x7262
>> diff --git a/drivers/hid/hid-multitouch.c b/drivers/hid/hid-multitouch.c
>> index 895d140..383adc9 100644
>> --- a/drivers/hid/hid-multitouch.c
>> +++ b/drivers/hid/hid-multitouch.c
>> @@ -1126,9 +1126,6 @@ static const struct hid_device_id mt_devices[] = {
>> { .driver_data = MT_CLS_EGALAX_SERIAL,
>> MT_USB_DEVICE(USB_VENDOR_ID_DWAV,
>> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224) },
>> - { .driver_data = MT_CLS_EGALAX,
>> - HID_USB_DEVICE(USB_VENDOR_ID_DWAV,
>> - USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224) },
>
> Ah, it seems different device definition.
> So, only ID is duplicated.
Actually the entry is also duplicated in hid-multitouch (not just the
idea). As the first one is always used, you can also remove the second
appearance of USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_7224.
Cheers,
Benjamin
>
>> { .driver_data = MT_CLS_EGALAX_SERIAL,
>> MT_USB_DEVICE(USB_VENDOR_ID_DWAV,
>> USB_DEVICE_ID_DWAV_EGALAX_MULTITOUCH_722A) },
>
prev parent reply other threads:[~2013-05-07 14:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 14:29 [PATCH 1/2] hid: sort IDs for D-WAV eGalax multitouch devices Andy Shevchenko
2013-05-07 14:29 ` [PATCH 2/2] hid: remove duplicate for D-WAV eGalax 0x7224 Andy Shevchenko
2013-05-07 14:34 ` Andy Shevchenko
2013-05-07 14:46 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=518913AF.7000800@redhat.com \
--to=benjamin.tissoires@redhat.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).