From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nick Dyer Subject: Re: [PATCH 10/53] Input: atmel_mxt_ts - Add memory access interface via sysfs Date: Thu, 06 Jun 2013 11:40:50 +0100 Message-ID: <51B06732.2050701@itdev.co.uk> References: <1370453866-16534-1-git-send-email-nick.dyer@itdev.co.uk> <7380889.l4hHqCT0mm@dtor-d630.eng.vmware.com> <51AF8730.4010507@itdev.co.uk> <1717403.GgHsbyUkDZ@dtor-d630.eng.vmware.com> <51AFA02B.3000604@itdev.co.uk> <20130605210715.GA16013@core.coreip.homeip.net> <20130606094822.GB1883@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: Received: from kdh-gw.itdev.co.uk ([89.21.227.133]:3475 "EHLO hermes.kdh.itdev.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932141Ab3FFKkw (ORCPT ); Thu, 6 Jun 2013 06:40:52 -0400 In-Reply-To: <20130606094822.GB1883@sirena.org.uk> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: Mark Brown Cc: Dmitry Torokhov , Daniel Kurtz , Henrik Rydberg , Joonyoung Shim , Alan.Bowens@atmel.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, pmeerw@pmeerw.net, bleung@chromium.org, olofj@chromium.org Mark Brown wrote: > On Wed, Jun 05, 2013 at 02:07:15PM -0700, Dmitry Torokhov wrote: >> On Wed, Jun 05, 2013 at 09:31:39PM +0100, Nick Dyer wrote: > >>> It's partly path dependence - it was implemented like this because regmap >>> wasn't in mainline at the point when I wrote it. Having a dependency on >>> regmap would now be a API break complicating support of customers using >>> older kernels than mainline. I would also have to update a bunch of > >> This was never a good argument for introducing an interface into the >> kernel. > > Indeed, and regmap is very easy to backport - it demands little from the > rest of the kernel and most of that is bus specific so you can pretty > much just copy it into an older kernel. That is good news. It would still be an extra thing to add to the docs, but not a blocking point. I am more worried about the address pointer handling and the I2C retries.