From: Sebastian Andrzej Siewior <bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
To: Lars-Peter Clausen <lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
Cc: Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Felipe Balbi <balbi-l0cyMroinI0@public.gmane.org>,
linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Dmitry Torokhov
<dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Jonathan Cameron <jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org>,
Pantelis Antoniou
<panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org>
Subject: Re: [PATCH 12/22] iio/ti_tscadc: Update with IIO map interface
Date: Mon, 10 Jun 2013 11:15:33 +0200 [thread overview]
Message-ID: <51B59935.3010506@linutronix.de> (raw)
In-Reply-To: <51B59071.9090908-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
On 06/10/2013 10:38 AM, Lars-Peter Clausen wrote:
>
> You don't need to describe the channels in devicetree, except setting the
> "#io-channel-cells" property of your ADC node to 1. You also need to initialize
> the of_node property of your iio_device's struct's 'dev' field to the your adc
> node.
Aha. So right now I do have in my device tree:
adc {
ti,adc-channels = <4>;
};
for the producer ADC node. But this seems wrong. Correct would be
adctsc: adc {
ti,adc-channels = <4>;
#io-channel-cells = <1>;
};
And the consumer can then specify everything. This seems to be looking
good. And with this the map piece can die.
Thanks.
>
> After that it's just a matter of using, e.g.
>
> io-channels = <&adc 1>;
> io-channel-names = "voltage";
>
> in your consumer.
>
> - Lars
Sebastian
next prev parent reply other threads:[~2013-06-10 9:15 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 16:24 AM335x tsc & adc, dt + cleanup take 3 Sebastian Andrzej Siewior
[not found] ` <1370449495-29981-1-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-05 16:24 ` [PATCH 01/22] mfd/ti_am335x_tscadc: remove regmap Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 02/22] mfd & input & iio/ti_am335x_adc: use one structure for ti_tscadc_dev Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 04/22] input/ti_am33x_tsc: Order of TSC wires, made configurable Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 06/22] input/ti_am33x_tsc: Add DT support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 07/22] input/ti_am33x_tsc: remove platform_data support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 08/22] iio/ti_am335x_adc: Add DT support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 14/22] arm/am33xx: add TSC/ADC mfd device support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 16/22] mfd & input/ti_am335x_tsc: rename device from tsc to TI-am335x-tsc Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 17/22] mfd & iio/ti_am335x_adc: rename device from tiadc to TI-am335x-adc Sebastian Andrzej Siewior
[not found] ` <1370449495-29981-18-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-08 9:19 ` Jonathan Cameron
2013-06-05 16:24 ` [PATCH 18/22] input/ti_am335x_adc: use only FIFO0 and clean up a little Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 19/22] input/ti_am335x_tsc: ACK the HW_PEN irq in ISR Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 20/22] input/ti_am335x_tsc: return IRQ_NONE if there was no IRQ for us Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 21/22] iio/ti_am335x_adc: Allow to specify input line Sebastian Andrzej Siewior
[not found] ` <1370449495-29981-22-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-08 9:24 ` Jonathan Cameron
[not found] ` <51B2F85E.2080805-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
2013-06-10 7:32 ` Sebastian Andrzej Siewior
2013-06-09 16:52 ` Lars-Peter Clausen
[not found] ` <51B4B2CE.3020300-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-06-11 7:55 ` Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 03/22] input/ti_am33x_tsc: Step enable bits made configurable Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 05/22] input/ti_am33x_tsc: remove unwanted fifo flush Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 09/22] iio/ti_am335x_adc: remove platform_data support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 10/22] mfd/ti_am335x_tscadc: Add DT support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 11/22] mfd/ti_am335x_tscadc: remove platform_data support Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 12/22] iio/ti_tscadc: Update with IIO map interface Sebastian Andrzej Siewior
[not found] ` <1370449495-29981-13-git-send-email-bigeasy-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-08 9:18 ` Jonathan Cameron
2013-06-09 16:41 ` Lars-Peter Clausen
2013-06-10 7:40 ` Sebastian Andrzej Siewior
[not found] ` <51B582D3.1050501-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2013-06-10 8:10 ` Pantelis Antoniou
2013-06-10 8:32 ` Lars-Peter Clausen
[not found] ` <51B58F39.7020405-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-06-10 8:33 ` Pantelis Antoniou
2013-06-10 8:38 ` Lars-Peter Clausen
[not found] ` <51B59071.9090908-Qo5EllUWu/uELgA04lAiVw@public.gmane.org>
2013-06-10 9:15 ` Sebastian Andrzej Siewior [this message]
2013-06-10 16:27 ` Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 13/22] mfd/ti_tscadc: deal with partial activation Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 15/22] input & mfd: ti_am335x_tsc remove remaining platform data pieces Sebastian Andrzej Siewior
2013-06-05 16:24 ` [PATCH 22/22] iio/ti_am335x_adc: check if we found the value Sebastian Andrzej Siewior
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51B59935.3010506@linutronix.de \
--to=bigeasy-hfztesqfncyowbw4kg4ksq@public.gmane.org \
--cc=balbi-l0cyMroinI0@public.gmane.org \
--cc=dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jic23-KWPb1pKIrIJaa/9Udqfwiw@public.gmane.org \
--cc=lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org \
--cc=linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-input-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=panto-wVdstyuyKrO8r51toPun2/C9HSW9iNxf@public.gmane.org \
--cc=sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).