linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Mack <zonque@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@vger.kernel.org, broonie@kernel.org,
	grant.likely@linaro.org, agust@denx.de, imre.deak@nokia.com,
	chf@fritzc.com
Subject: Re: [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct
Date: Mon, 01 Jul 2013 08:48:50 +0200	[thread overview]
Message-ID: <51D12652.3090804@gmail.com> (raw)
In-Reply-To: <20130701013324.GA10755@core.coreip.homeip.net>

Hi Dmitry,

On 01.07.2013 03:33, Dmitry Torokhov wrote:
> On Sun, Jun 30, 2013 at 11:09:14PM +0200, Daniel Mack wrote:
>> +
>> +	if (!pdata->model)
>> +		pdata->model = 7846;
>> +
>> +	if (!pdata->vref_delay_usecs)
>> +		pdata->vref_delay_usecs = 100;
>> +
>> +	if (!pdata->x_plate_ohms)
>> +		pdata->x_plate_ohms = 400;
>> +
>> +	if (!pdata->pressure_max)
>> +		pdata->pressure_max = ~0;
> 
> We should not be changing the platform data as the device does not own
> it and it may well be declared as a constant structure.

We don't change the platform data that is passed in via the driver core.
We keep a copy of it in our private strucz (that's what the subject
says) and in case of DT, we modify that copy. The passed pdata is left
untouched.



Thanks,
Daniel


  reply	other threads:[~2013-07-01  6:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-30 21:09 [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct Daniel Mack
2013-06-30 21:09 ` [PATCH RESEND v2 2/2] Input: touchscreen: ads7846: add device tree bindings Daniel Mack
2013-07-01  1:35   ` Dmitry Torokhov
2013-07-01  3:12     ` Dmitry Torokhov
2013-07-01  6:52     ` Daniel Mack
2013-07-01  1:33 ` [PATCH RESEND v2 1/2] Input: touchscreen: ads7846: keep copy of pdata in private struct Dmitry Torokhov
2013-07-01  6:48   ` Daniel Mack [this message]
2013-07-01  7:09     ` Dmitry Torokhov
2013-07-01  7:14       ` Daniel Mack
2013-07-01  7:21         ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2013-05-22 17:57 Daniel Mack
2013-06-23 13:01 ` Daniel Mack

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51D12652.3090804@gmail.com \
    --to=zonque@gmail.com \
    --cc=agust@denx.de \
    --cc=broonie@kernel.org \
    --cc=chf@fritzc.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=grant.likely@linaro.org \
    --cc=imre.deak@nokia.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).